Uh oh!
There was an error while loading. Please reload this page.
Wave B-1 PR-A: test fortification + privacy fix - #33
Conversation
… helper Wave B-1 preparation. The aiohttp non-2xx test will hit /notfound; the exception-path test needs a closed port to connect to. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…nfo (#19) The substring-based implementation correctly handled canonical URLs but preserved fragments and userinfo, leaking either into event.url. The urlparse-based rewrite drops both alongside the query string, and is robust to encoded `%3F` / `%23` in the path. Adds TestPrivacy (6 tests) pinning the contract: - RawEvent has no header-shaped fields - Authorization header values never appear in any captured field - Query string secrets never appear in any captured field - _strip_query handles %3F-in-path, drops #fragment, drops user:pass@ Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…on / no-double-count (#9) Mirrors TestUrllib3 / TestHttpxAsync shape. Wave A added only body-sizing tests; these pin the four invariants the README promises. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pins the README claim that _post_cloud uses urllib.request specifically to avoid self-instrumentation. A regression here would make every flush generate another event to flush — silent telemetry amplification. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Counterpart to test_no_retry_on_4xx. Verifies that 500s retry max_retries times (so max_retries+1 total POSTs), and that the sleep durations match the documented min(1.0 * 2**attempt, 10.0) schedule. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…es (#9) - test_legacy_flush_interval_emits_deprecation_warning — verifies the legacy seconds-based flush_interval still works and emits the documented DeprecationWarning. - test_dispose_prevents_further_flushes — guards the dispose path against regression where the timer or atexit hook would keep firing post-dispose. - test_overflow_triggers_early_flush — pins the on_event would_overflow branch that protects the API from a >max_buckets payload. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
?find #19._strip_queryrewritten to useurllib.parse.urlparse— drops fragment + userinfo alongside the query string.main(Wave A):_UNSETsentinel in_interceptor.py:48defers theurllib3.util.Timeout.DEFAULT_TIMEOUTlookup to function-body time, and the deadpool_connections/pool_maxsizekwargs are gone from the_patched_urlopensignature. No further code change required — see audit comment.test_interceptor.py,test_transport.py,test_init.py,test_aggregator.py. Closes most of Test gaps: aiohttp paths, privacy claim, self-instrumentation, 5xx retry #9 (the remaining two missing-dep tests land in PR-B Wave B-1 PR-B: missing-dep test coverage #34).Tests added
TestPrivacy(6) — header non-capture, query non-leak,_strip_queryunit cases (encoded%3F, fragment, userinfo).TestAiohttp(4) — success, non-2xx, exception path, no-double-count.TestSelfInstrumentation(1) — cloud flush does not trigger urllib3 patch.Test5xxRetry(2) — exact attempt count, exponential backoff schedule.test_legacy_flush_interval_emits_deprecation_warning.test_dispose_prevents_further_flushes.test_overflow_triggers_early_flush.Code change
recost/_interceptor.py::_strip_query— one function rewritten.tests/test_interceptor.py::_Handler.do_GET— extended for/notfound.Test plan
mypy recost/clean.ruff check recost/ tests/clean.pytest tests/test_interceptor.py::TestPrivacy -vconfirms the 6 privacy contracts.🤖 Generated with Claude Code