Uh oh!
There was an error while loading. Please reload this page.
feat: restrict account_id in GET /api/chats to ORG/RECOUP keys - #171
Merged
sweetmantech merged 2 commits intoJan 29, 2026
Conversation
Contributor
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Braintrust eval reportCatalog Opportunity Analysis Evaluation (HEAD-1769700932)
Catalog Songs Count Evaluation (HEAD-1769700932)
First Week Album Sales Evaluation (HEAD-1769700932)
Memory & Storage Tools Evaluation (HEAD-1769700932)
Monthly Listeners Tracking Evaluation (HEAD-1769700932)
Search Web Tool Evaluation (HEAD-1769700932)
Social Scraping Evaluation (HEAD-1769700932)
Spotify Followers Evaluation (HEAD-1769700932)
Spotify Tools Evaluation (HEAD-1769700933)
TikTok Analytics Questions Evaluation (HEAD-1769700932)
|
- Make account_id query parameter optional in /api/chats - Personal API keys can no longer specify account_id (403 error) - Org keys can only filter by account_id for org members - Recoup admin keys can filter by any account_id - Personal keys: Returns only their own chats - Org keys: Returns all org member chats - Recoup admin: Returns all chats Uses snake_case naming (account_id, artist_id, org_id) to match API docs. This matches the authorization pattern used in /api/pulses. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
sweetmantechforce-pushed
the
sweetmantech/myc-4062-api-apichat-account_id-only-for-org-recoup-keys-same-as
branch
from
January 29, 2026 15:18
f9c6484 to
995e218CompareThe rooms table has no FK from account_id to accounts, so the join approach was silently returning empty results. Changed to fetch org member account IDs via getAccountOrganizations first, then filter rooms. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
sweetmantech
deleted the
sweetmantech/myc-4062-api-apichat-account_id-only-for-org-recoup-keys-same-as
branch
January 29, 2026 15:42
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account_idquery parameter optional in GET/api/chats(previously required)account_id- returns 403 erroraccount_idonly for accounts that are members of their organizationaccount_idaccount_idparameter:This matches the authorization pattern used in
/api/pulses.Test plan
account_idparamaccount_idaccount_idparamaccount_idfor org membersaccount_idaccount_idparamaccount_id🤖 Generated with Claude Code