Uh oh!
There was an error while loading. Please reload this page.
feat: add optional songs filter to content creation endpoint - #348
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThe pull request extends the content-creation pipeline to accept and propagate an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sweetmantech
commented
Mar 30, 2026
Preview Deployment Test ResultsDeployment URL: Results: All 4 tests passed ✅
Summary
|
sweetmantech
commented
Mar 30, 2026
Preview Deployment Test Results (Real Artist)Deployment URL: Results: All tests passed ✅
Summary
|
Made-with: Cursor
Pass through an optional songs array from POST /api/content/create to the Trigger.dev task so the pipeline can restrict which songs it picks from. Made-with: Cursor
Split into separate PR #376 per SRP feedback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6e5a2bb to
fc6cabeComparesweetmantech
commented
Mar 30, 2026
E2E Test Results — |
| Step | Status |
|---|---|
Song filtering (hiccups) | Filtered to specified songs |
| Selected song | hiccups.mp3 |
| Clip | 0.8s start, 15s duration |
| Clip lyrics | "The worst kind of hangover came from you I woke up with a headache and you in my bed..." |
| Clip mood | Annoyed, Regretful |
| Image generation | View image |
| Video | View final video |
| Caption | "i swear my brain is just a tangled mess of piano melodies and half-formed thoughts at 3 am..." |
Summary
songs: ["hiccups"]correctly filtered to only the "hiccups" track- Full pipeline completed end-to-end: image → video → caption → ffmpeg render
- Branch rebased onto latest
test
Tested by Claude Code against production Trigger.dev deployment.
Uh oh!
There was an error while loading. Please reload this page.
Summary
songsfield to Zod schema invalidateCreateContentBodysongsthroughcreateContentHandlerintotriggerCreateContentpayloadsongs?: string[]toTriggerCreateContentPayloadinterfaceTest plan
POST /api/content/createwithsongs: ["hiccups"]triggers task with song filtersongspreserves current behaviorMade with Cursor
Summary by CodeRabbit
Release Notes