Promote test → main: artist update endpoints (#431)

[sweetmantech]

Promotes PR #431 (migrate artist manual update to PATCH /api/artists/{id}) from test to main.

Verified on preview:

• PATCH name/label/instruction ✅
• Toggle pinned true/false/true ✅
• All CI checks green on feat: migrate artist manual update to PATCH /api/artists/{id} #431 (format, lint, test, cubic reviewer)

🤖 Generated with Claude Code

---

Summary by cubic

Adds PATCH /api/artists/{id} to update artist name, profile fields, socials, and per-account pinned state in a single request. Returns the caller’s current pin state so name-only updates don’t clobber UI state.

• New Features

  • New PATCH endpoint accepts name, image, instruction, label, knowledges, profileUrls, and pinned; validates with Zod and responds with the updated artist plus the caller’s pinned.
  • Upserts account_info via upsertArtistInfoFields: preserves omitted fields, de-duplicates knowledges by URL, treats empty label as null; moves knowledgeSchema to lib/artist/knowledge.
  • Adds setAccountArtistPin to persist pin state and includes it in the response; updates socials when profileUrls are provided.

• Bug Fixes

  • Replaces failing Supabase upsert for pins with select+update/insert to avoid 500s when no unique constraint exists.
  • Prevents returning pinned: false on name-only updates by attaching the requester’s pin state to the response.

^{Written for commit 7d36cb9. Summary will update on new commits.}

Summary by CodeRabbit

Release Notes

• New Features
  • Artist profiles can now be updated with changes to name, image, description, label, knowledge resources, and social links.
  • Added support for pinning and unpinning artists to your account.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
recoup-api	Ready	Preview	Apr 17, 2026 7:48pm

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

This PR implements a PATCH /api/artists/{id} endpoint to update artist details. It adds request validation, a handler that conditionally updates account-level fields and upserts artist profile info, manages artist-account pinning relationships, and consolidates the Knowledge type definition into a dedicated module for consistency across multiple validation schemas.

Changes

Cohort / File(s)	Summary
Route handler app/api/artists/[id]/route.ts	Adds new exported PATCH function that delegates to updateArtistHandler, following the same pattern as the existing DELETE route.
Request validation lib/artists/validateUpdateArtistRequest.ts	New module defining updateArtistBodySchema with optional fields (name, image, instruction, label, knowledges, profileUrls, pinned), a refinement requiring at least one field, and validation logic that checks auth, artist existence, and account authorization before returning validated payload.
Update handler lib/artists/updateArtistHandler.ts	Core PATCH handler orchestrating conditional updates to account fields, artist profile info, socials, and account-artist pinning; fetches updated details and returns 200 response or appropriate error (404/500) with CORS headers.
Artist info operations lib/artists/upsertArtistInfoFields.ts	New module providing upsertArtistInfoFields that inserts or updates artist profile fields (image, instruction, label, knowledges) with deduplication by URL and null-mapping logic for empty labels.
Account-artist pinning lib/artists/setAccountArtistPin.ts	New module implementing setAccountArtistPin that updates pinned status if account-artist linkage exists, otherwise creates new linkage with pinned flag.
Knowledge schema consolidation lib/artist/knowledge.ts, lib/artist/updateArtistProfile.ts, lib/artist/createKnowledgeBase.ts, lib/accounts/validateUpdateAccountRequest.ts	Extracts Knowledge type and knowledgeSchema (with URL validation) into dedicated lib/artist/knowledge.ts; updates imports in dependent files to reference the centralized definition.
Database operations lib/supabase/account_artist_ids/insertAccountArtistId.ts, lib/supabase/account_artist_ids/selectAccountArtistId.ts, lib/supabase/account_artist_ids/updateAccountArtistPinById.ts, lib/supabase/accounts/selectAccountWithArtistDetails.ts	New and updated query functions: insertAccountArtistId accepts optional pinned flag; selectAccountArtistId now retrieves id, artist_id, and pinned; new updateAccountArtistPinById updates pinned status; new selectAccountWithArtistDetails fetches account with nested artist info and socials.

Sequence Diagram

sequenceDiagram
participant Client
participant Route as API Route<br/>PATCH /artists/{id}
participant Validator as validateUpdateArtistRequest
participant Handler as updateArtistHandler
participant DB as Database<br/>(Supabase)
participant Cache as Response
Client->>Route: PATCH /artists/{id}
Route->>Handler: updateArtistHandler(request, params)
Handler->>Validator: validateUpdateArtistRequest(request, id)
Validator->>DB: validateAccountParams()
Validator->>DB: selectAccounts(id)
Validator->>DB: checkAccountArtistAccess()
alt Validation fails
Validator-->>Handler: NextResponse (400/403/404)
Handler-->>Route: error response
Route-->>Client: error JSON
else Validation succeeds
Validator-->>Handler: ValidatedUpdateArtistRequest
Handler->>DB: updateAccountInfo() / insertAccountInfo()
Handler->>DB: upsertArtistInfoFields()
Handler->>DB: updateAccountSocials() (if profileUrls)
Handler->>DB: setAccountArtistPin() (if pinned provided)
Handler->>DB: selectAccountWithArtistDetails(artistId)
Handler->>DB: selectAccountArtistId(accountId, artistId)
DB-->>Handler: artist details + pin status
Handler-->>Route: 200 response with artist JSON
Route-->>Client: formatted artist data
end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: migrate artist manual update to PATCH /api/artists/{id} #431: Directly implements the same PATCH endpoint and accompanying handler/helper modules across multiple files.
• feat: add artist detail read endpoint #416: Modifies the same artist detail surface and introduces similar database helper functions.
• feat: Artist TikTok Connections via Composio #170: Introduces checkAccountArtistAccess, which is invoked in the new validation logic to enforce authorization.

Poem

🎨 A patch to paint the artist's way,
With knowledge schemas on display,
Updates flow from client to DB,
Pinned with care, now artists see,
The PATCH that lets them freely say! 📌✨

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Solid & Clean Code	⚠️ Warning	PR violates DRY, SRP, and type safety principles: manual error response constructions instead of utility, unconditional side effects without guards, missing return type annotations, and coupled validation logic.	Replace manual error responses with errorResponse() utility, add guard clause for upsertArtistInfoFields, annotate selectAccountArtistId return type, and extract validation sequence into helper.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}