[code-quality] Add RemoveDataProviderParamKeysRector

[TomasVotruba]

No description provided.

[samsonasik]

It seems buggy on yield when code quality set used in phpunit 10, it probably related with how version usage, or phpunit version check is needed on this rule:

PHP Warning: Undefined array key "fuelOrders"

I will look into it.

[samsonasik]

@TomasVotruba actually, we already have rule that change array index name to match argument of data provider; NamedArgumentForDataProviderRector

https://getrector.com/rule-detail/named-argument-for-data-provider-rector

that specifically cover phpunit 11, I think this RemoveDataProviderParamKeysRector can be optional, which we can unregister from code quality set, so people can manually use when actually needed, wdyt?

[TomasVotruba]

The code quality set promotes best practices and opinionated saint defaults. Often these keys are added randomly to only couple data providers.

Also, the param name - string key is unnecessary complexity. The order is good enough.

If someone is using these keys consistently and on purpose, this rule can be skipped.

[MacDada]

Well, I think I'm gonna skip this rule, because I use the keys to (sometimes) increase readability of data providers.

For example:

Without the keys (Rector removed them) I'd have to look into the methods that use the DataProvider to see what the "not so obvious" true and false mean here. The valid key helps here.

Another example:

Unless you know a better way to document / increase readability of such DataProviders…

[TomasVotruba]

@MacDada Hi, thanks for feedback and specific screenshot examples. It's clear to me this rule is making more mess.

To be honest, I don't recall why exactly I've added this rule. It was something related to miss-matching keys to parameter names, but not sure.

Saying that, I'd suggest removing this rule from the set and deprecated it. Could you make it happen via PR?