Uh oh!
There was an error while loading. Please reload this page.
[Config] Restore default values for RectorConfig->parallel() config similar to original <=0.18.x version - #5472
Merged
Merged
Conversation
samsonasik
commented
Jan 16, 2024
MemberAuthor
All checks have passed 🎉 @TomasVotruba I think it is ready. |
staabm
approved these changes
Jan 16, 2024
kenjis
approved these changes
Jan 16, 2024
samsonasikforce-pushed
the
samsonasik-patch-1
branch
from
January 16, 2024 10:23
60ccdba to
6a36233Comparesamsonasik
commented
Jan 16, 2024
MemberAuthor
Rebased 👍 |
samsonasik
commented
Jan 16, 2024
| * as we run PHPStan as well | ||
| */ | ||
| public function parallel(int $processTimeout = 120, int $maxNumberOfProcess = 32, int $jobSize = 20): void | ||
| public function parallel(int $processTimeout = 120, int $maxNumberOfProcess = 16, int $jobSize = 16): void |
MemberAuthor
There was a problem hiding this comment.
@TomasVotruba I updated jobSize to 16 per your request on chat ;)
Member
There was a problem hiding this comment.
Thanks. How is the performance on your projects? :)
MemberAuthor
There was a problem hiding this comment.
Tested on CodeIgniter 4 on 4.5 branch, it seems working ok
https://github.com/codeigniter4/CodeIgniter4/actions/runs/7540420845/job/20524948567?pr=8418
Member
There was a problem hiding this comment.
@samsonasik Could you share a composer.json setup for testing this PR? I'd like community to test this, before we go for merge.
MemberAuthor
There was a problem hiding this comment.
It actually CodeIgniter4 project, switch to 4.5 branch:
git clone git@github.com:codeigniter4/CodeIgniter4.git
git checkout 4.5
The composer.json is as follow:
{
"name": "codeigniter4/codeigniter4",
"description": "The CodeIgniter framework v4",
"license": "MIT",
"type": "project",
"homepage": "https://codeigniter.com",
"support": {
"forum": "https://forum.codeigniter.com/",
"source": "https://github.com/codeigniter4/CodeIgniter4",
"slack": "https://codeigniterchat.slack.com"
},
"require": {
"php": "^8.1",
"ext-intl": "*",
"ext-mbstring": "*",
"laminas/laminas-escaper": "^2.13",
"psr/log": "^3.0"
},
"require-dev": {
"codeigniter/coding-standard": "^1.7",
"codeigniter/phpstan-codeigniter": "^1.4",
"ergebnis/composer-normalize": "^2.28",
"fakerphp/faker": "^1.9",
"friendsofphp/php-cs-fixer": "~3.46.0",
"kint-php/kint": "^5.0.4",
"mikey179/vfsstream": "^1.6",
"nexusphp/cs-config": "^3.6",
"nexusphp/tachycardia": "^1.0",
"phpstan/extension-installer": "^1.3",
"phpstan/phpstan": "^1.10.2",
"phpstan/phpstan-strict-rules": "^1.5",
"phpunit/phpcov": "^8.2",
"phpunit/phpunit": "^9.1",
"predis/predis": "^1.1 || ^2.0",
"rector/rector": "0.19.0",
"vimeo/psalm": "^5.0"
},
"replace": {
"codeigniter4/framework": "self.version"
},
"suggest": {
"ext-curl": "If you use CURLRequest class",
"ext-dom": "If you use TestResponse",
"ext-exif": "If you run Image class tests",
"ext-fileinfo": "Improves mime type detection for files",
"ext-gd": "If you use Image class GDHandler",
"ext-imagick": "If you use Image class ImageMagickHandler",
"ext-libxml": "If you use TestResponse",
"ext-memcache": "If you use Cache class MemcachedHandler with Memcache",
"ext-memcached": "If you use Cache class MemcachedHandler with Memcached",
"ext-mysqli": "If you use MySQL",
"ext-oci8": "If you use Oracle Database",
"ext-pgsql": "If you use PostgreSQL",
"ext-readline": "Improves CLI::input() usability",
"ext-redis": "If you use Cache class RedisHandler",
"ext-simplexml": "If you format XML",
"ext-sodium": "If you use Encryption SodiumHandler",
"ext-sqlite3": "If you use SQLite3",
"ext-sqlsrv": "If you use SQL Server",
"ext-xdebug": "If you use CIUnitTestCase::assertHeaderEmitted()"
},
"autoload": {
"psr-4": {
"CodeIgniter\\": "system/",
"Config\\": "app/Config/"
},
"exclude-from-classmap": [
"**/Database/Migrations/**"
]
},
"autoload-dev": {
"psr-4": {
"CodeIgniter\\": "tests/system/",
"Utils\\": "utils/"
}
},
"config": {
"allow-plugins": {
"ergebnis/composer-normalize": true,
"phpstan/extension-installer": true
},
"optimize-autoloader": true,
"preferred-install": "dist",
"sort-packages": true
},
"extra": {
"branch-alias": {
"dev-develop": "4.x-dev"
}
},
"scripts": {
"post-update-cmd": [
"CodeIgniter\\ComposerScripts::postUpdate"
],
"analyze": [
"Composer\\Config::disableProcessTimeout",
"bash -c \"XDEBUG_MODE=off phpstan analyse\"",
"rector process --dry-run"
],
"cs": [
"Composer\\Config::disableProcessTimeout",
"php-cs-fixer fix --ansi --verbose --dry-run --diff --config=.php-cs-fixer.user-guide.php",
"php-cs-fixer fix --ansi --verbose --dry-run --diff --config=.php-cs-fixer.no-header.php",
"php-cs-fixer fix --ansi --verbose --dry-run --diff"
],
"cs-fix": [
"Composer\\Config::disableProcessTimeout",
"php-cs-fixer fix --ansi --verbose --diff --config=.php-cs-fixer.user-guide.php",
"php-cs-fixer fix --ansi --verbose --diff --config=.php-cs-fixer.no-header.php",
"php-cs-fixer fix --ansi --verbose --diff"
],
"sa": "@analyze",
"style": "@cs-fix",
"test": "phpunit"
},
"scripts-descriptions": {
"analyze": "Run static analysis",
"cs": "Check the coding style",
"cs-fix": "Fix the coding style",
"test": "Run unit tests"
}
}
@kenjis test in his PR:
for old config, even with 120 seconds timeout, but 20 job size, and got timeout
Member
There was a problem hiding this comment.
@samsonasik I meant how to install this branch commit into any project. So other can try in their projects.
MemberAuthor
There was a problem hiding this comment.
The steps can be:
composer config minimum-stability dev
composer config prefer-stable true
composer require rector/rector:dev-main --dev --ansi
Then update parallel config:
$rectorConfig->parallel(120, 16,16);5 tasks
TomasVotruba
commented
Jan 23, 2024
Member
Thanks a lot for feedback and patience 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
120, 16, 15is mostly working on CI, which has big files (3000-4000 lines per file) so I propose to rollback it.