Skip to content
/rector-srcPublic

[Php85] Add ArrayKeyExistsNullToEmptyStringRector - #7183

Merged
TomasVotruba merged 14 commits into
rectorphp:mainfrom
arshidkv12:8.5_ArrayKey…StringRector
Aug 28, 2025

Hidden character warning

The head ref may contain hidden characters: "8.5_ArrayKey\u2026StringRector"
Merged

[Php85] Add ArrayKeyExistsNullToEmptyStringRector#7183
TomasVotruba merged 14 commits into
rectorphp:mainfrom
arshidkv12:8.5_ArrayKey…StringRector

Conversation

@arshidkv12

@arshidkv12arshidkv12 commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/NodeManipulator/NullToStrictStringConverter.php Outdated
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/NodeManipulator/NullToStrictStringConverter.php Outdated
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/NodeManipulator/NullToStrictStringConverter.php Outdated
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/NodeManipulator/NullToStrictStringConverter.php Outdated
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php81/NodeManipulator/NullToStrictStringConverter.php
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php Outdated
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadsrc/ValueObject/PhpVersionFeature.php Outdated
samsonasik
samsonasik requested changes Aug 28, 2025
View reviewed changes

@samsonasiksamsonasik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run:

bin/rector && composer fix-cs

to fix CI

@samsonasiksamsonasik changed the title Add Rector to replace null keys in array_key_exists with empty string [Php85] Add ArrayKeyExistsNullToEmptyStringRectorAug 28, 2025
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php Outdated
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php Outdated
samsonasik
samsonasik reviewed Aug 28, 2025
View reviewed changes
Comment threadrules/Php85/Rector/FuncCall/ArrayKeyExistsNullToEmptyStringRector.php Outdated
samsonasik
samsonasik approved these changes Aug 28, 2025
View reviewed changes

@samsonasiksamsonasik left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@TomasVotruba

TomasVotruba commented Aug 28, 2025•
edited
Loading

Copy link
Copy Markdown
Member

LGTM 👍 Thank you @arshidkv12

@TomasVotruba
TomasVotruba merged commit aeb8a67 into rectorphp:mainAug 28, 2025
49 checks passed
@arshidkv12

arshidkv12 commented Aug 28, 2025

Copy link
Copy Markdown
ContributorAuthor

Thanks for the quick review.

@samsonasik

samsonasik commented Aug 28, 2025

Copy link
Copy Markdown
Member

key seems can be int, I will check and ensure it not casted to string

https://3v4l.org/ZcBbZ

@samsonasiksamsonasik mentioned this pull request Aug 28, 2025
Merged
@samsonasik

samsonasik commented Aug 28, 2025

Copy link
Copy Markdown
Member

#7189

@samsonasik

samsonasik commented Aug 28, 2025

Copy link
Copy Markdown
Member

Btw, the deprecation is not yet merged on php-src:

so if in the PR not merged (likely will be merged) when php 8.5 released, we can revert this rule :)

@github-actions

github-actionsBot commented Feb 1, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Feb 1, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@TomasVotrubaTomasVotrubaAwaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arshidkv12@TomasVotruba@samsonasik