Skip to content

test: see if ci passes on main - #7846

Closed
calebdw wants to merge 2 commits into
rectorphp:mainfrom
calebdw:calebdw/push-pqkkozvwtloq
Closed

test: see if ci passes on main#7846
calebdw wants to merge 2 commits into
rectorphp:mainfrom
calebdw:calebdw/push-pqkkozvwtloq

Conversation

@calebdw

@calebdwcalebdw commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@TomasVotruba, @samsonasik

Important

The problem appears to be in the latest PHPStan 2.1.35 release

@calebdw

Copy link
Copy Markdown
ContributorAuthor

@TomasVotruba, @samsonasik please see driftingly/rector-laravel#466, something in the last release (either in rector or phpstan) is causing both this ci to fail and rector-laravel to fail

I will continue to dig on my end

@calebdw
calebdwforce-pushed the calebdw/push-pqkkozvwtloq branch 2 times, most recently from c38c47c to 408db5dCompareJanuary 20, 2026 22:01
@calebdw
calebdwforce-pushed the calebdw/push-pqkkozvwtloq branch 2 times, most recently from 2babcc9 to 819efa6CompareJanuary 20, 2026 22:06
@calebdw

calebdw commented Jan 20, 2026

Copy link
Copy Markdown
ContributorAuthor

@TomasVotruba, @samsonasik the problem seems to be in these last 2 commits:

image

Reverting them (and pinning the phpstan version to 2.1.33) allows the PHP Tests to pass (the other tests are related to the other packages likely pulling in the latest phpstan)

image

@calebdw
calebdwforce-pushed the calebdw/push-pqkkozvwtloq branch 2 times, most recently from a3c8336 to 5973fa7CompareJanuary 20, 2026 22:13
@samsonasik

Copy link
Copy Markdown
Member

@calebdw I will check in separate PR :)

The rector-downgrade-php already phpstan 2.1.35

https://github.com/rectorphp/rector-src/actions/runs/21189253042/job/60951735934?pr=7846#step:6:32

@samsonasik

Copy link
Copy Markdown
Member

@calebdw I created 2 PRs that show that in PHPStan 2.1.34 (working), and PHPStan 2.1.35 (not working)

@calebdwcalebdw closed this Jan 21, 2026
@calebdw
calebdw deleted the calebdw/push-pqkkozvwtloq branch January 21, 2026 01:12
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.

@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Aug 23, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@calebdw@samsonasik