Bump to PHPStan ^2.1.35

[samsonasik]

@calebdw@TomasVotruba this PR bump to PHPStan 2.1.35.

It seems scope process node is changed internally on PHPStan side.

see comparison of Before vs After Bump to PHPStan 2.1.35

• 2.1.34 (working) : [test] Test pin PHPStan 2.1.34 (working) rector-downgrade-php#359
• 2.1.35 (not working): [test] Test bump PHPStan 2.1.35 (not working) rector-downgrade-php#360

Ref issue reported on PHPStan side:

• PHPStan 2.1.35 cause error on rector-downgrade-php phpstan/phpstan#13992

I will check if we can tweak here, as this got error on this rector-src as well :)

[samsonasik]

The PHPStan 2.1.35 cause error in this rector-src unit test as well:

• https://github.com/rectorphp/rector-src/actions/runs/21192815853/job/60962649715?pr=7847#step:5:114

I will check if we can tweak here :)

[samsonasik]

I created failing test case on PHPStan repository:

• [PHPStan 2.1.35] Add failing test where original Node not processed under VirtualNode on NodeScopeResolver::processNodes() phpstan/phpstan-src#4795

hope it can be resolved there :)

[TomasVotruba]

I've pinned PHPStan 2.1.34 in the composer.json (61f8719) and released a new tag 2.3.3.

It won't fix old installs (as composer rarely downgrades a package), but will prevent next updates

https://github.com/rectorphp/rector/releases/tag/2.3.3

[samsonasik]

@TomasVotruba thank you, we can temporary add on packages-tests CI.

 - run: | composer install --ansi composer require --dev phpstan/phpstan:2.1.34

as the use of:

composer require rector/rector-src dev-main#${{github.event.pull_request.head.sha}} --no-update

not forcing phpstan 2.1.34.

I will create new PR to temporary pin it so the main branch will all green :)

Ref PR:

• Temporary require --dev phpstan/phpstan:2.1.34 on packages-tests CI uses to make main branch CI green #7849

[calebdw]

Looks like a fix might have been released: phpstan/phpstan#13983 (comment)

So, please, if $scope->getType() doesn't work for you in your isset() rule, use $scope->getScopeType() instead. Thank you for understanding.

[samsonasik]

@calebdw I will create separate PR for bump to phpstan ^2.1.36 and verify the fix :)

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.