Uh oh!
There was an error while loading. Please reload this page.
Group fixture checks into single Code Analysis job - #8368
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge 3 separate fixture-related matrix entries in
code_analysis.yamlinto one Fixture Checks job. Fewer separate GitHub checks, same coverage.Before — 3 checks:
Check before/after test fixture on no-changesCheck fixture classes are different to nodesCheck no "*.php" files in rules Fixture directoryAfter — 1 check
Fixture Checks:Note: if branch protection lists the old 3 check names as required, update required checks to
Fixture Checks.