Uh oh!
There was an error while loading. Please reload this page.
[DI] Autodiscover TypeMapper via most-specific match - #8372
Merged
Conversation
TomasVotrubaforce-pushed
the
typemapper-autodiscover
branch
from
August 25, 2026 07:31
98cdf42 to
1641750CompareTomasVotruba
enabled auto-merge (squash)
August 25, 2026 07:57
TomasVotruba
disabled auto-merge
August 25, 2026 08:05
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of three parallel experiments removing order-sensitive
registerTagged()collections in favor ofautodiscover().TypeMappercould not be autodiscovered before becausePHPStanStaticTypeMappermatched mappers by firstinstanceofmatch in registration order — a mapper for a child type (ConstantArrayType) had to be registered before the mapper for its parent (ArrayType), or the parent would always win.autodiscover()uses filesystem order, which does not honor that.This removes the order dependency instead of encoding it: the consumer now picks the most specific matching mapper (deepest in the type hierarchy), so registration order no longer matters.
With that,
TYPE_MAPPER_CLASSES(29 entries) drops to a singleautodiscover()call, and the now-obsoleteTypeMapperOrderTest(which guarded the old registration-order invariant) is removed.Verified directly against the real mappers:
ConstantArrayTypeArrayShapeNode(specific, not the generic array mapper)ClassStringTypeclass-string(not theStringTypemapper)ObjectType\Foo(not theTypeWithClassNamemapper)Interface added to the class-leak skip list (implementors are now discovered, not referenced).