Uh oh!
There was an error while loading. Please reload this page.
[Cleanup] Remove write-only CallLikeThisBoundClosureArgsNodeVisitor and its unread attribute - #8373
Merged
Merged
Conversation
…nd its unread attribute
TomasVotrubaforce-pushed
the
tv-remove-dead-node-visitors
branch
from
August 25, 2026 07:22
c778948 to
b887698CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CallLikeThisBoundClosureArgsNodeVisitorsets the AST attributeIS_CLOSURE_USES_THIS('has_this_closure') which is never read anywhere — not insrc/,rules/, nor any siblingdev-mainpackage (rector-downgrade-php,rector-symfony,rector-phpunit, ...). The onlyhasAttributeon the key sits inside the visitor's own guard; nothing consumes it.It runs on every traversal via
DECORATING_NODE_VISITOR_CLASSESyet produces nothing — pure overhead.Removes:
CallLikeThisBoundClosureArgsNodeVisitorCallLikeExpectsThisBoundClosureArgsAnalyzer(only that visitor used it)AttributeKey::IS_CLOSURE_USES_THISconstantLazyContainerFactoryPure deletion, 147 lines, no behavior change:
private const array DECORATING_NODE_VISITOR_CLASSES = [ ... ClassConstFetchNodeVisitor::class, - CallLikeThisBoundClosureArgsNodeVisitor::class, ArgNotAcceptingClosureNodeVisitor::class, ];Note:
PhpVersionConditionNodeVisitorwas in an earlier revision of this PR but is kept — itsPHP_VERSION_CONDITIONEDattribute is read cross-package byDowngradeHashAlgorithmXxHashRectorinrector-downgrade-php.