Uh oh!
There was an error while loading. Please reload this page.
[DI] Autodiscover PhpParserNodeMapper via most-specific match - #8374
Merged
Conversation
TomasVotrubaforce-pushed
the
phpparsernodemapper-autodiscover
branch
2 times, most recently
from
August 25, 2026 07:32
fe9f427 to
c71d9c5CompareTomasVotrubaforce-pushed
the
phpparsernodemapper-autodiscover
branch
from
August 25, 2026 08:08
d789756 to
f10682bCompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of three parallel experiments removing order-sensitive
registerTagged()collections in favor ofautodiscover().PhpParserNodeMappermatched by firstis_a()match in registration order, soFullyQualifiedNodeMapperhad to be registered beforeNameNodeMapper(FullyQualified extends Name) andStringNodeMapperbeforeExprNodeMapper(String_ extends Expr).autodiscover()filesystem order does not honor that.Fix removes the order dependency: the consumer picks the most specific matching mapper (deepest node type), so order stops mattering.
PHP_PARSER_NODE_MAPPER_CLASSEScollapses to oneautodiscover()call.Verified directly:
FullyQualifiedFullyQualifiedObjectType(not the genericNamemapper)String_StringType(not theExprmapper)NameMixedTypeInterface added to the class-leak skip list.