Uh oh!
There was an error while loading. Please reload this page.
[DI] Autodiscover AnnotationToAttributeMapper via mutually exclusive candidates - #8375
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of three parallel experiments removing order-sensitive
registerTagged()collections in favor ofautodiscover().AnnotationToAttributeMappermatched by firstisCandidate()in registration order. The one order-sensitive overlap:StringAnnotationToAttributeMapper::isCandidate()returnedis_string($value)— a superset ofClassConstFetchAnnotationToAttributeMapper(is_string && contains '::' && not quoted). A value likeFoo::BARmatched both, and the curated order let the class-const mapper win.autodiscover()filesystem order would not honor that.Rather than a consumer change, this makes the two candidates mutually exclusive, so match order is irrelevant:
ANNOTATION_TO_ATTRIBUTE_MAPPER_CLASSEScollapses to oneautodiscover()call.Verified the two mappers no longer both claim any value (behavior identical to the old first-match order):
Foo::BARplain"quoted::x"Interface added to the class-leak skip list.