Skip to content

Improvements to validate_toolchain for release testing - #1094

Open
AdamSaleh wants to merge 10 commits into
redhat-developer:masterfrom
rh-gitops-release-qa:master
Open

Improvements to validate_toolchain for release testing#1094
AdamSaleh wants to merge 10 commits into
redhat-developer:masterfrom
rh-gitops-release-qa:master

Conversation

@AdamSaleh

@AdamSalehAdamSaleh commented Mar 4, 2026

Copy link
Copy Markdown
Member

This is no longer just cherrypick from v1.19 branch.

Because the validate_toolchain test needs frequent updates, I changed it to use external file to store the expected versions. It also provides a mechanism to automatically update the values from the server under test. In future this could lead to self-updating tests, where on failure, a new PR would be opened automatically with the versions that the test actually saw available for review.

Also, a signifficant improvement is that the test feilure now looks like:

 [FAILED] Expected
<map[string]string | len:5>: {
"argocd": "v3.3.2",
"dex": "v2.43.0",
"helm": "v3.19.4",
"kustomize": "v5.8.1",
"redis": "7.2.11",
}
to equal
<map[string]string | len:5>: {
"argocd": "v3.3.0",
"dex": "v2.43.0",
"helm": "v3.19.4",
"kustomize": "v5.8.1",
"redis": "7.2.11",
}

instead of previously investigation requiring Expected "v3.3.2" to equal "v3.3.0" :)

This PR was written with assistance of claude code.

@openshift-ci

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jannfis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

olivergondza
olivergondza previously approved these changes Mar 5, 2026
@AdamSalehAdamSaleh changed the title Modify tests for interop test suite (#1076)Improvements to validate_toolchain for release testingMar 10, 2026
varshab1210and others added 3 commits March 18, 2026 19:30
* modify tests for interop
Signed-off-by: Varsha B <vab@redhat.com>
* move the test to sequential
Signed-off-by: Varsha B <vab@redhat.com>
---------
Signed-off-by: Varsha B <vab@redhat.com>
…ut CSV to find the one that is not a copy,
and compare against easier updated snapshot.
Assisted-by: Claude <usersafety@anthropic.com>
Signed-off-by: Adam Saleh <adam@asaleh.net>
…versions to make checking an updating easier.
If env-var E2E_UPDATE_SNAPSHOTS=1 is present, the file will autoupdate.
Assisted-by: Claude <usersafety@anthropic.com>
Signed-off-by: Adam Saleh <adam@asaleh.net>
E2E Test Botand others added 3 commits March 24, 2026 12:57
…ut CSV to find the one that is not a copy,
and compare against easier updated snapshot.
Assisted-by: Claude <usersafety@anthropic.com>
Signed-off-by: Adam Saleh <adam@asaleh.net>
Signed-off-by: Adam Saleh <adam@asaleh.net>
@openshift-ci

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jgwest

Copy link
Copy Markdown
Member

/retest

@openshift-ci

Copy link
Copy Markdown

@AdamSaleh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
ci/prow/unit677a234linktrue/test unit
ci/prow/v4.19-kuttl-parallel677a234linktrue/test v4.19-kuttl-parallel
ci/prow/v4.19-ci-index-gitops-operator-bundle677a234linktrue/test v4.19-ci-index-gitops-operator-bundle
ci/prow/v4.14-kuttl-sequential677a234linkfalse/test v4.14-kuttl-sequential
ci/prow/v4.14-kuttl-parallel677a234linkfalse/test v4.14-kuttl-parallel
ci/prow/v4.19-kuttl-sequential677a234linktrue/test v4.19-kuttl-sequential
ci/prow/v4.14-e2e677a234linktrue/test v4.14-e2e
ci/prow/v4.14-images677a234linktrue/test v4.14-images
ci/prow/v4.14-ci-index-gitops-operator-bundle677a234linktrue/test v4.14-ci-index-gitops-operator-bundle
ci/prow/v4.19-e2e677a234linktrue/test v4.19-e2e
ci/prow/v4.19-images677a234linktrue/test v4.19-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@AdamSaleh@jgwest@olivergondza@openshift-merge-robot@varshab1210