Uh oh!
There was an error while loading. Please reload this page.
Internalize argocd operator (DO NOT SQUASH-MERGE) - #1263
Open
olivergondza wants to merge 1305 commits into
Open
Conversation
Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
… argocd-image-updater master branch (#1924) Signed-off-by: Cheng Fang <cfang@redhat.com>
Signed-off-by: dkarpele <karpelevich@gmail.com>
Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
… (#1928) Signed-off-by: akhil nittala <nakhil@redhat.com>
… (#1927) Signed-off-by: Alka Kumari <alkumari@redhat.com>
…866) * WIP Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Code clenup and commenting Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Add proposal doc Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * merge transform func, add tests for configmap and secret Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * add env var to disable optimization, update docs Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * fix CI lint failure Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * incorporate PR review Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * update IsTrackedByOperator func to take in runtime.Object Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> * Fix minor issues Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Minor code comment updates Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Add unit test for client Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix linting Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Use positive notion for env Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Remove space and return patch error to caller Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Add unit test for patch error Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Move trackedby check out of referesh check func Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com> Co-authored-by: Anand Kumar Singh <anandrkskd@gmail.com>
Signed-off-by: Mike Ng <ming@redhat.com>
Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
* Support notifications in any namespace Signed-off-by: nmirasch <neus.miras@gmail.com> * Removed cluster roles and added self-service-notification-enabled to command Signed-off-by: nmirasch <neus.miras@gmail.com> * Add NotificationsConfiguration CR in the spec.notifications.sourceNamespaces Signed-off-by: nmirasch <neus.miras@gmail.com> * Add empty NotificationsConfiguration CR in the source namespaces instead of propagating the configs Signed-off-by: nmirasch <neus.miras@gmail.com> * Create NotificationsConfiguration CR in the source namespaces without spec Signed-off-by: nmirasch <neus.miras@gmail.com> --------- Signed-off-by: nmirasch <neus.miras@gmail.com>
Signed-off-by: Mike Ng <ming@redhat.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
…when HA enabled cluster has Only 3 worker nodes (#1933) * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> * fix: redis ha proxy rolling update pod in pending state Signed-off-by: akhil nittala <nakhil@redhat.com> --------- Signed-off-by: akhil nittala <nakhil@redhat.com>
…ild (#1911) Bumps ubi8/ubi-minimal from `58b1dc5` to `951ee3c`. --- updated-dependencies: - dependency-name: ubi8/ubi-minimal dependency-version: 951ee3cabb74246821ae31c2b808b7789310f5509882c153b7b178aaaeefa2d3 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dkarpele <karpelevich@gmail.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v5) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…938) * Documentation for support of notifications in any namespace Signed-off-by: nmirasch <neus.miras@gmail.com> * Minor grammatical fix: use proper abbreviation formatting. Signed-off-by: nmirasch <neus.miras@gmail.com> * Removed extra content Signed-off-by: nmirasch <neus.miras@gmail.com> --------- Signed-off-by: nmirasch <neus.miras@gmail.com>
* Add testing for support notifications in any namespace Signed-off-by: nmirasch <neus.miras@gmail.com> * NotificationController ClusterRole reconciliation added Signed-off-by: nmirasch <neus.miras@gmail.com> * Avoid printing error when skipping reconciliation of resources regarding the target namespace is not enabled Signed-off-by: nmirasch <neus.miras@gmail.com> * Add checks Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * changed test description Signed-off-by: nmirasch <neus.miras@gmail.com> --------- Signed-off-by: nmirasch <neus.miras@gmail.com> Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> Co-authored-by: Siddhesh Ghadi <sghadi1203@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.43.0 to 0.45.0. - [Commits](golang/crypto@v0.43.0...v0.45.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.45.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
* add namespace validation for notification resources Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> * Fix e2e test Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com> --------- Signed-off-by: Siddhesh Ghadi <sghadi1203@gmail.com>
* fix: namespace validation for sourcenamespace Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com> * fix: namespace validation for sourcenamespace Assisted by: Cursor Signed-off-by: Jayendra Parsai <jparsai@redhat.com> * fix: namespace validation for sourcenamespace Signed-off-by: Jonathan West <jgwest@gmail.com> * fix: namespace validation for sourcenamespace Signed-off-by: Jonathan West <jgwest@gmail.com> --------- Signed-off-by: Jayendra Parsai <jparsai@redhat.com> Signed-off-by: Jonathan West <jgwest@gmail.com> Co-authored-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Jonathan West <jonwest@redhat.com>
Signed-off-by: Jonathan West <jgwest@gmail.com>
Signed-off-by: dkarpele <karpelevich@gmail.com>
…bernetes resources (#2320) * fix: adjust agent's clusterole to have read permissions for common kubernetes resources Signed-off-by: Christopher Coco <ccoco@redhat.com> * ci: rerun Signed-off-by: Christopher Coco <ccoco@redhat.com> * ci: rerun Signed-off-by: Christopher Coco <ccoco@redhat.com> --------- Signed-off-by: Christopher Coco <ccoco@redhat.com>
* docs: Document readthedocs.org development Signed-off-by: Oliver Gondža <ogondza@gmail.com> * feat: Generate apidocs using elastic/crd-ref-docs Signed-off-by: Oliver Gondža <ogondza@gmail.com> * feat: Build apidocs before the site is built Signed-off-by: Oliver Gondža <ogondza@gmail.com> * Update variable name Signed-off-by: Oliver Gondža <ogondza@gmail.com> * fix: Fix notifications link, unify URI for `make serve-docs` Signed-off-by: Oliver Gondža <ogondza@gmail.com> * fix: docs in crd-ref-docs.config.yaml Signed-off-by: Oliver Gondža <ogondza@gmail.com> * fix(Makefile): Separate OPERATOR_SDK_VERSION and KUBERNETES_API_VERSION Signed-off-by: Oliver Gondža <ogondza@gmail.com> * feat(Makefile): Generate both alpha and beta apidocs Signed-off-by: Oliver Gondža <ogondza@gmail.com> --------- Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…0 to 3.5.1 (#2324) * chore(deps): bump image-updater from 1.2.2 to 1.3.0 Signed-off-by: Cheng Fang <cfang@redhat.com> * bump argocd from 3.5.0 to 3.5.1 Signed-off-by: Cheng Fang <cfang@redhat.com> --------- Signed-off-by: Cheng Fang <cfang@redhat.com>
…(#2330) logr.Logger.Error() expects a static message plus structured key-value pairs; printf-style %s arguments were being passed directly and treated as invalid keys. Convert all call sites to the key-value convention. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.54.0 to 0.55.0. - [Commits](golang/crypto@v0.54.0...v0.55.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.55.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/mod](https://github.com/golang/mod) from 0.38.0 to 0.40.0. - [Commits](golang/mod@v0.38.0...v0.40.0) --- updated-dependencies: - dependency-name: golang.org/x/mod dependency-version: 0.40.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…8d3b0cfbae5dec656b025a32cab Merge remote-tracking branch 'internalize' into internalize-argocd-operator Signed-off-by: Oliver Gondža <ogondza@gmail.com>
…ion so it builds Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
This unifies the manifest with argocd-operator/, not the remote repo. Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Important Review skippedToo many files! This PR contains 837 files, which is 537 over the limit of 300. To get a review, reduce the PR to 300 files or fewer by splitting it into smaller PRs or changing its base branch. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (13)
📒 Files selected for processing (837)
You can disable this status message by setting the Use the checkbox below for a quick retry:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
olivergondzaforce-pushed
the
internalize-argocd-operator
branch
from
August 20, 2026 18:35
2c79489 to
2e31dc7Compareolivergondza
commented
Aug 20, 2026
CollaboratorAuthor
/test v4.19-e2e |
olivergondza
commented
Aug 20, 2026
CollaboratorAuthor
/retest |
1 similar comment
olivergondza
commented
Aug 20, 2026
CollaboratorAuthor
/retest |
Signed-off-by: Oliver Gondža <ogondza@gmail.com>
@olivergondza: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
olivergondza
commented
Aug 21, 2026
CollaboratorAuthor
Tests failing because: containerStatuses:
- image: quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/argocd-rhel9:mainimageID: ""lastState: {}name: argocd-serverready: falserestartCount: 0started: falsestate:
waiting:
message: 'Back-off pulling image "quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/argocd-rhel9:main": ErrImagePull: unable to pull image or OCI artifact: pull image err: initializing source docker://quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/argocd-rhel9:main: reading manifest main in quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/argocd-rhel9: unauthorized: access to the requested resource is not authorized; artifact err: get manifest: build image source: reading manifest main in quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/argocd-rhel9: unauthorized: access to the requested resource is not authorized'reason: ImagePullBackOff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do / why we need it:
This is a first step in factoring-in the argocd-operator. It purposefully does the minimum, to move forward in manageable steps. The goal of the PR is to do just enough for CI to pass to provide the needed safety net and have the codebase releasable.
Effective changes post merge: https://github.com/olivergondza/gitops-operator/commits/internalize-argocd-operator/?since=2026-08-20
go.modreplace for a new directoryargocd-operatorone754075fa4f028d3b0cfbae5dec656b025a32cab.git filter-repo+git merge --allow-unrelated-historiesThe DCO is tricky. The imported history is rebased (rewritten for the move to the directory), so it has lost its signatures. I suggest merging as it - an alternative is that someone (I) signs it all now, but it does not add much to the security.Have you updated the necessary documentation?
Which issue(s) this PR fixes:
Fixes #?
Test acceptance criteria:
How to test changes / Special notes to the reviewer:
The exact procedure used to internalize the remote repository.
!!! DO NOT SQUASH-MERGE !!!