fix: adjust tests to work locally

[gashcrumb]

Description

Make test assertions independent of terminal color formatting and restore the process working directory after package-test fixtures are removed. This keeps yarn test reliable both in interactive terminals and across Jest worker scheduling.

Test Plan

• nvm exec 24.18.0 yarn test
• nvm exec 24.18.0 env FORCE_COLOR=1 yarn test
• yarn prettier:check
• yarn lint:check

[fullsend-ai-review]

🤖 Review · ⚠️ Cancelled · Started 12:23 PM UTC · Ended 12:26 PM UTC

Commit: cbb9b54 · View workflow run →

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 12:27 PM UTC · Completed 12:40 PM UTC

Commit: e1ab770 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.87

[fullsend-ai-review]

Risk Assessment: low (1/5)

Details

Score reduced from prior 2 to 1 because the changed file (check-heavy-deps.test.ts) has a materially cleaner git history than the previously assessed file (command.test.ts): 0 fix/revert commits vs 2, and 1 distinct author vs 2 — a specific articulable delta that drives Tier 2 sub-score to ~1.3 and the 62/38-weighted composite to ~1.2, rounding to 1.

Previous run

Risk Assessment: moderate (2/5)

Details

Tier 1 signals unchanged from prior assessment (2 test files, 23 lines, 100% test ratio, no protected paths or dependency changes); Tier 2 comparable — command.test.ts shows 2 fix/revert commits and 2 authors — per re-review anchoring no specific articulable reason to reduce from the prior score of 2, so the moderate rating is preserved.

Previous run (2)

Risk Assessment: moderate (2/5)

Details

Tiny test-only change (2 files, 25 lines, 100% test ratio) with no protected paths, CI, or dependency changes; modest Tier 2 uplift from two recent authors and one fix commit brings the weighted composite (62%/38%, no linked issue) to 2 (moderate).

Previous run (3)

Risk Assessment: low (1/5)

Details

Minimal-risk test-only change: 2 test files with 28 lines changed, no production code, no protected paths, no security-sensitive files, no CI or dependency changes, and low git history churn.

[fullsend-ai-review]

Looks good to me

Previous run

Review

Findings

Low

• [test-integrity] src/commands/package-dynamic-plugins/command.test.ts:31 — Redundant duplicate assignment: origCwd = process.cwd() appears twice in beforeEach. The base branch already captures the original working directory at line 27 (before fs.mkdtempSync, which does not alter the cwd). The PR adds a second identical assignment at line 31, between mkdtempSync and process.chdir(tmpDir), producing the same value. The second assignment is dead code and misleads readers into thinking the earlier capture was insufficient.
  Remediation: Remove the duplicate origCwd = process.cwd(); at line 31. The existing assignment at line 27 is sufficient and correct.

---

Next steps:

• /fs-fix — agent addresses review findings automatically
• /fs-fix <your instruction> — agent fixes with your specific guidance
• Push commits directly — review re-runs automatically on push
• /fs-fix-stop — disable automatic fix runs for this PR

Previous run (2)

Looks good to me

Previous run (3)

Review

Findings

Low

• [dead code / misleading guard] src/commands/package-dynamic-plugins/command.test.ts:40 — The guard if (process.cwd() !== originalCwd) { throw ... } is unreachable. process.chdir(originalCwd) is called unconditionally on line 35, and nothing between line 35 and line 40 can change the working directory back. The condition will always be false, so the guard can never fire. As written it suggests protection against something that has already been handled, which could mislead future readers into thinking it is actively tested.
  Remediation: Either remove the guard (the process.chdir(originalCwd) on line 35 is sufficient) or restructure so the guard runs before the forced restore and verifies that the test itself left the cwd correct, e.g.: capture process.cwd() before the chdir, assert, then chdir.

---

Next steps:

• /fs-fix — agent addresses review findings automatically
• /fs-fix <your instruction> — agent fixes with your specific guidance
• Push commits directly — review re-runs automatically on push
• /fs-fix-stop — disable automatic fix runs for this PR

[fullsend-ai-review]

🤖 Finished Review · ❌ Failure (validation failed after 1 iteration(s)) · Started 1:28 PM UTC · Completed 1:30 PM UTC

Commit: b2f0e49 · View workflow run →

Runtime: claude · Model: opus → claude-opus-5 · Effort: high

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 4:18 PM UTC · Completed 4:27 PM UTC

Commit: f5f6f48 · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-4-6 · Effort: high · Cost: $1.30

Superseded by updated review

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 5:42 PM UTC · Completed 5:54 PM UTC

Commit: b1e8d53 · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-4-6 · Effort: high · Cost: $1.79

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 6:21 PM UTC · Completed 6:32 PM UTC

Commit: 2be61c0 · View workflow run →

Runtime: claude · Model: sonnet → claude-sonnet-4-6 · Effort: high · Cost: $1.60

Superseded by updated review