feat: derive Facet if facet feature is active - #179
Merged
Conversation
Erik1000
marked this pull request as ready for review
January 23, 2026 12:25
Erik1000
commented
Jan 30, 2026
ContributorAuthor
Well, i will look at this around Wednesday next week |
Erik1000
commented
Feb 7, 2026
ContributorAuthor
Well, the failing clippy test is unrelated to my change. Should I allow the lint on this branch or just wait and rebase on main if a fix is available? |
Uh oh!
There was an error while loading. Please reload this page.
mbrubeck
commented
Aug 21, 2026
Collaborator
Sorry for the delay! I rebased this to the latest versions of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently patches facet to latest commit on main until the next release is available