chore(ci): add workflow scanning, group security updates, harden checkouts - #46
Open
ManukMinasyan wants to merge 1 commit into
Open
ManukMinasyan wants to merge 1 commit into
ManukMinasyan wants to merge 1 commit into
Conversation
…kouts No workflow ran zizmor here, so the security tab reported no analysis rather than a clean result. Adding the audit surfaces eight findings, all fixed in this change: checkouts that never push stop persisting a credential, the gh-pages checkout that does push says so, step outputs move out of `run:` into `env:`, and tests.yml declares read-only permissions instead of inheriting the default write token. The composer group only covered development dependencies, so production advisories arrived one PR each. Every ecosystem now has a security-updates group; `applies-to` defaults to version updates, which the previous groups relied on implicitly.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same cleanup as relaticle/custom-fields#217, applied here.
No workflow scanning at all
This repository has no
zizmor.yml, so its security tab said "no analysis found" rather than reporting a clean result. Added the audit workflow used by the sibling packages. It finds 8 issues, all fixed here:artipacked: checkouts persisting a credential they never use.template-injection: step outputs interpolated straight intorun:bodies.excessive-permissions:tests.ymldeclared nopermissions:block, so it inherited the default token.Verified with
zizmor --no-online-audits: 8 findings before, 0 after.The
gh-pagescheckout indeploy-docs.ymlis pushed to later in the job, so it keeps its credential and carries an inline ignore saying why.Security update grouping
The composer group was scoped to
dependency-type: development, so production advisories arrived one PR per advisory. Every ecosystem now has asecurity-updatesgroup alongside its version-updates group.applies-todefaults to version updates, which the previous groups relied on implicitly.Also done outside this PR
Dependabot security updates were disabled on this repository. Now enabled.