feat(universes): Add place-level user restriction support by commonly-ts · Pull Request #9 · relatiocc/opencloud

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

commonly-ts · 2025-11-20T13:10:40Z

Description

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

Type of Change

✨ New feature (non-breaking change which adds functionality)
✅ Test update

Changes Made

Adds placeId parameter to universes.updateUserRestriction
Updates universes.updateUserRestriction to use an options object for universeId, placeId and body.
Adds placeId check to the updateUserRestriction test.

Testing

All existing tests pass (pnpm test)
Added new tests for new functionality
Tested manually (describe below)

Manual Testing

Simple string concatenation so no manual testing needed

Code Quality

My code follows the project's coding style
I have run pnpm lint and fixed any issues
I have run pnpm format to format my code
I have run pnpm typecheck and there are no type errors
I have reviewed my own code

Documentation

I have updated the relevant documentation (if applicable)
I have added/updated JSDoc comments for new/modified code

Screenshots/Recordings

Checklist

I have read the CONTRIBUTING.md guide
My PR title follows the Conventional Commits format
I have rebased my branch on the latest main branch
I have tested my changes against the Roblox Open Cloud API (if applicable)
This PR is ready for review

Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

codecov · 2025-11-20T13:11:19Z

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/resources/universes.ts	91.66%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

commonly-ts · 2025-11-20T13:12:08Z

I would agree if the method's parameters are a bit icky now, I'm fine with changing it into options typed with an interface if you'd like

marinofranz

I agree, let's make this into an options object so we can re-use
There are a couple of other methods that have this feature as well, you can integrate the options object into that as well if you're feeling up for it 🙂

Make sure to add this to a test or create a new one so coverage can pass

Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz

There are a few changes that I want to address regarding the code style, the logic is perfectly fine 🙂

commonly-ts · 2025-11-23T02:47:18Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.

could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz · 2025-11-25T20:29:49Z

also wondering about readability for duration as its not particularly clear that it needs to be in seconds with "s" at the end, unless you go and read the API docs.
could rename it to durationSeconds and have it as a number, and then parse it inside the function or is this SDK just a base wrapper without that sort of thing?

We try to stick to just the API reference but we can eventually figure out a helper function for that, this will do for now 🙂
There's just one missing test that should test if duration is an empty string to pass coverage

Add place-level user restriction support
809ded3
Extends the Universes class to allow updating user restrictions at the place level by accepting an optional placeId parameter. Adjusts the resource path logic to handle both universe-level and place-level user restrictions.

commonly-ts requested a review from marinofranz as a code owner November 20, 2025 13:10

marinofranz requested changes Nov 20, 2025
View reviewed changes

marinofranz added the enhancement New feature or request label Nov 20, 2025

commonly-ts added 2 commits November 21, 2025 12:33

Added options to updateUserRestriction
1ec8557

Updated updateUserRestriction test
ab86f51

commonly-ts requested a review from marinofranz November 20, 2025 23:34

commonly-ts added 3 commits November 21, 2025 15:05

fix: handle empty duration in user restriction update
5c65efe
Prevents API errors by setting 'duration' to undefined if it is an empty string when updating user restrictions. This avoids sending invalid data that would result in a 400 response from the API.

fix: linting
14603fd

fix: handle empty duration in user restriction updates
28620fc
Refactored Universes.updateUserRestriction to set duration as undefined if an empty string is provided, preventing API 400 errors. Updated related test to verify correct handling of empty duration values.

marinofranz requested changes Nov 22, 2025
View reviewed changes

Comment threadsrc/resources/universes.ts Outdated
Comment threadsrc/resources/universes.ts Outdated
Comment threadsrc/resources/universes.ts Outdated
Comment threadsrc/resources/universes.ts
Comment threadsrc/resources/universes.ts Outdated

Refactor updateUserRestriction parameter order
16d5526
Swapped the order of universeId and userRestrictionId in updateUserRestriction to match API expectations. Updated related type definitions, documentation, and tests for consistency.

marinofranz mentioned this pull request Nov 25, 2025
[Feature]: Add place-level support for all user restriction endpoints #10
Open
3 tasks