Skip to content

upgrade remark to version 8 and unified to version 9 - #425

Merged
wooorm merged 1 commit into
remarkjs:v5from
ChristianMurphy:v5
Oct 8, 2020
Merged

upgrade remark to version 8 and unified to version 9#425
wooorm merged 1 commit into
remarkjs:v5from
ChristianMurphy:v5

Conversation

@ChristianMurphy

Copy link
Copy Markdown
Member

These versions bring improvements to commonmark compliance and official typings.

These versions bring improvements to commonmark compliance and official typings.
Comment threadindex.d.ts
Comment threadtest/react-markdown.test.js
@ChristianMurphy

Copy link
Copy Markdown
MemberAuthor

/cc @wooorm

@gilisho

Copy link
Copy Markdown
Contributor

Can this be merged? 🤞
I came across this issue, and apparently the solution is to really bump the version of remark-parser.

@starpit

Copy link
Copy Markdown
Contributor

we'd also like to see this merged. anything we can do to help?

@gilisho

Copy link
Copy Markdown
Contributor

@rexxars sorry for tagging, but I would be really happy if this could be merged, so I'm just pinging.

@wooorm

Copy link
Copy Markdown
Member

@ChristianMurphy I can merge this now, I believe?

@ChristianMurphy

Copy link
Copy Markdown
MemberAuthor

Yep, this should be good to go

@wooorm
wooorm merged commit 2f0e228 into remarkjs:v5Oct 8, 2020
@wooorm

Copy link
Copy Markdown
Member

This was referenced Oct 9, 2020
wooorm pushed a commit that referenced this pull request Oct 15, 2020
These versions bring improvements to commonmark compliance and official typings.
ClosesGH-425.
Reviewed-by: Titus Wormer <tituswormer@gmail.com>
wooorm pushed a commit that referenced this pull request Oct 15, 2020
These versions bring improvements to commonmark compliance and official typings.
ClosesGH-425.
Reviewed-by: Titus Wormer <tituswormer@gmail.com>
@wooormwooorm added the 💪 phase/solved Post is done label Aug 7, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 area/depsThis affects dependencies💪 phase/solvedPost is done

Development

Successfully merging this pull request may close these issues.

4 participants

@ChristianMurphy@gilisho@starpit@wooorm