Uh oh!
There was an error while loading. Please reload this page.
Removing linkTarget option - #762
Conversation
This comment has been minimized.
This comment has been minimized.
wooorm
commented
Aug 25, 2023
Thanks for the PR! I think this is a good idea. And I’ll be doing a major in a couple weeks. So this is 👍 in my opinion. What do you think, @remcohaszing, @ChristianMurphy? Just jotting down for myself that I should also probably add an example to the readme to show how |
remcohaszing
commented
Aug 25, 2023
Yep, I agree |
ChristianMurphy
left a comment
There was a problem hiding this comment.
Seems like a good idea to me as well. 👍
It fits well with the overarching goal of better alignment of this package with the rest of the unified/remark ecosystem.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #762 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 5 5 Lines 754 733 -21 =========================================
- Hits 754 733 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
louh
commented
Nov 11, 2023
Documentation should really be updated to show specifically how to migrate from I had to figure this out myself. In case anyone is coming here looking for help: Before: <ReactMarkdownlinkTarget="_blank">{yourContent}</ReactMarkdown>After: importrehypeExternalLinksfrom'rehype-external-links'<ReactMarkdownrehypePlugins={[[rehypeExternalLinks,{target: '_blank'}]]}>{yourContent}</ReactMarkdown>Basically Hope that helps someone. |
wooorm
commented
Nov 11, 2023
It’s documented https://github.com/remarkjs/react-markdown/releases/tag/9.0.0. |
Initial checklist
Description of changes
Following the discussion in #761, I removed the redundant
linkTargetprop.This functionality can still be applied using plugins, or the
componentsprop.