Skip to content

Remove support for className prop - #799

Closed
remcohaszing wants to merge 4 commits into
mainfrom
deprecate-classname
Closed

Remove support for className prop#799
remcohaszing wants to merge 4 commits into
mainfrom
deprecate-classname

Conversation

@remcohaszing

@remcohaszingremcohaszing commented Nov 15, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This deprecates the className prop, but does not remove it yet. Users should wrap the <Markdown> component inside a <div> manually instead.

Closes#781

@remcohaszing
Deprecate the className prop
ea2fa56
Users should wrap the `<Markdown>` component inside a `<div>` manually
instead.
Closes#781
@github-actionsgithub-actionsBot added the 👋 phase/new Post is being triaged automatically label Nov 15, 2023
@github-actions

This comment has been minimized.

Sign in to view
JounQin
JounQin requested changes Nov 16, 2023
View reviewed changes

@JounQinJounQin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#781 (comment)

@github-actionsgithub-actionsBot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Nov 16, 2023
@codecov-commenter

codecov-commenter commented Nov 17, 2023•
edited by codecov Bot
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2245c64) to head (40143b1).
Report is 33 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #799 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 3 3 Lines 1354 1337 -17 Branches 113 110 -3 =========================================
- Hits 1354 1337 -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remcohaszing

remcohaszing commented Nov 17, 2023

Copy link
Copy Markdown
MemberAuthor

I misinterpreted the meaning of the word deprecated here originally in a late evening.

I interpret deprecated as planned for change or removal with a warning. In this project deprecated means removed with an error, making deprecations semver major.

@remcohaszingremcohaszing added 🗄 area/interface This affects the public interface 🧑 semver/major This is a change labels Nov 17, 2023
@wooorm

wooorm commented Nov 17, 2023

Copy link
Copy Markdown
Member

Can you drop the changelog entry? I’ll write the changelog/migration manually when the time is there!
Otherwise, 👍

@remcohaszing

remcohaszing commented Nov 17, 2023

Copy link
Copy Markdown
MemberAuthor

Sure 👍

It just feeld a bit weird to link a non-existent header from the code.

@wooorm

wooorm commented Nov 17, 2023

Copy link
Copy Markdown
Member

Ah that’s why, hmm, then I’d do a <!-- To do: add heading for slug deprecate-classname -->
Or these two comments might be enough!

@remcohaszing

remcohaszing commented Nov 17, 2023

Copy link
Copy Markdown
MemberAuthor

Since this change is breaking, this PR shouldn’t be merged until the next major anyway. I think this PR thread is plenty reminder once this gets merged. :)

@wooormwooorm changed the title Deprecate the className propRemove support for className propFeb 13, 2025
@wooormwooorm added the 💪 phase/solved Post is done label Feb 20, 2025
@github-actions

This comment has been minimized.

Sign in to view
@github-actionsgithub-actionsBot removed the 🤞 phase/open Post is being triaged manually label Feb 20, 2025
@wooorm

wooorm commented Feb 20, 2025

Copy link
Copy Markdown
Member

Released in 10.0.0!

@wooorm
wooorm deleted the deprecate-classname branch February 20, 2025 13:03
@coderabbitaicoderabbitaiBot mentioned this pull request Jun 3, 2026
Open
14 tasks
@coderabbitaicoderabbitaiBot mentioned this pull request Jul 14, 2026
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JounQinJounQinJounQin requested changes
@wooormwooormwooorm approved these changes
@ChristianMurphyChristianMurphyChristianMurphy approved these changes

Assignees

No one assigned

Labels

🗄 area/interfaceThis affects the public interface💪 phase/solvedPost is done🧑 semver/majorThis is a change

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove support for className prop

5 participants

@remcohaszing@codecov-commenter@wooorm@ChristianMurphy@JounQin