forked from callumalpass/tasknotes
- Notifications
You must be signed in to change notification settings - Fork 0
feat(dependencies): acknowledge and surface status readiness for advanced dependency types#20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renatomen
wants to merge
33
commits into
mainChoose a base branch
from
feat/dependency-enable-acknowledgement
base:main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Uh oh!
There was an error while loading. Please reload this page.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
f2cfe3f
feat(status): add lifecycle category to StatusConfig
renatomen e4419b2
feat(status): category dropdown and lifecycle pill in status settings
renatomen b0e342f
fix(review): address status-lifecycle review findings
renatomen 06e8bbe
refactor(status): three always-on categories (Not started / Started /…
renatomen 8ad4bbb
feat(deps): per-endpoint start/finish blocked computation in Dependen…
renatomen 731e8ee
feat(deps): thread per-endpoint blocked state onto TaskInfo
renatomen 1babe39
test(deps): extend issue-1100 dependencyCache mock with per-endpoint …
renatomen 32f0174
feat(dependencies): show per-endpoint blocked state on card surfaces
renatomen 14b81dc
feat(dependencies): author reltype + lag from both sides of the edit …
renatomen f4426d1
feat(settings): add the advanced dependency types opt-in to Features
renatomen 34049d0
feat(bases): reflect per-endpoint blocking in rendered views; documen…
renatomen acd7654
fix(review): harden dependency edge cases from the branch review
renatomen 77ce058
fix(task-card): persist blocked-by / blocking expansion across re-ren…
renatomen 41d2cb6
feat(dependencies): status-readiness guidance for advanced dependency…
renatomen 98b5258
feat(task-card): break the blocking tooltip down by endpoint
renatomen 9521789
feat(task-card): stack the blocking tooltip breakdown on its own lines
renatomen 27a67bd
feat(i18n): add context-menu relationship-type labels for the depende…
renatomen 5ca4e5e
feat(dependencies): choose the relationship type from the context-men…
renatomen d3eca2c
test: complete task-card expandedProjectsService mocks with blocking …
renatomen 9e662d1
refactor(dependencies): move the reltype menu builder into the tested…
renatomen a56e566
test(dependencies): cover forward blocking-predecessor accessors and …
renatomen f8f7408
fix(task-card): stop re-expanding relationship sub-lists on every render
renatomen 62a163c
refactor(task-card): drop now-unused blocked/blocking expansion persi…
renatomen a53b407
fix(bases): skip the data-update re-render when the data is unchanged
renatomen b01f018
feat(dependencies): report which start categories a status set is mis…
renatomen ead77ec
feat(settings): open a settings sub-tab from outside the settings view
renatomen 06747a0
feat(dependencies): acknowledge missing start categories before enabling
renatomen 12157de
feat(dependencies): gate enabling advanced types on acknowledgement
renatomen 73c25e7
feat(dependencies): make the status readiness warning visible
renatomen cf196af
feat(dependencies): show start-category readiness where statuses are …
renatomen 5e84ce9
refactor(dependencies): share the readiness vocabulary and keep both …
renatomen 68cfe45
fix(dependencies): rebuild dependency state when a status is recatego…
renatomen 3d092cc
fix(dependencies): state the consequence that matches the missing cat…
renatomen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When users consult the property-type reference after reading this new documentation,
docs/settings/property-types-reference.md:307still says the UI only creates finish-to-start dependencies and that relationship-specific semantics are not evaluated. That directly contradicts the feature documented here, so update the reference alongside this behavior to prevent users from receiving mutually exclusive guidance.Useful? React with 👍 / 👎.