Add BitmapContext extension methods for direct drawing operations - #94
Open
reneschulte with Copilot wants to merge 4 commits into
Open
Add BitmapContext extension methods for direct drawing operations#94reneschulte with Copilot wants to merge 4 commits into
reneschulte with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: reneschulte <7439129+reneschulte@users.noreply.github.com>
Co-authored-by: reneschulte <7439129+reneschulte@users.noreply.github.com>
Co-authored-by: reneschulte <7439129+reneschulte@users.noreply.github.com>
CopilotAI
changed the title
[WIP] Suggesting major modificationAdd BitmapContext extension methods for direct drawing operationsMay 21, 2025
reneschulte
marked this pull request as ready for review
June 2, 2025 07:05
reneschulte
commented
Jun 2, 2025
Owner
@epsi1on Can you take a look if these are the wrappers and interfaces you had in mind? |
Contributor
Seems yes, but not completely. Although the BitmapContext does not allocated every time If you are OK with this idea, I can make a pull request. Thanks |
epsi1on
commented
Jun 11, 2025
Contributor
Instead of replacing all extension methods of original code: publicstaticvoidDrawLineAa(thisWriteableBitmapbmp,intx1,inty1,intx2,inty2,intcolor,Rect?clipRect=null){//actual pixel manipulation code here}new code: publicstaticvoidDrawLineAa(thisWriteableBitmapbmp,intx1,inty1,intx2,inty2,intcolor,Rect?clipRect=null){using(varctx=bmp.GetBitmapContext())DrawLineAa(ctx,x1,y1,x2,y2,color,clipRect);}publicstaticvoidDrawLineAa(thisBitmapContextctx,intx1,inty1,intx2,inty2,intcolor,Rect?clipRect=null){//actual pixel manipulation code here} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds extension methods for the
BitmapContextclass that allow users to perform drawing operations directly on aBitmapContextinstead of having to go through theWriteableBitmap. This enables more efficient code when doing multiple drawing operations since theBitmapContextonly needs to be created once.Key changes
BitmapContextExtensionsclass with extension methods that mirror existingWriteableBitmapextension methodsUsage example
Before, users needed to use
WriteableBitmapmethods that create/dispose contexts internally:Now, users can reuse the same context for multiple operations:
This provides better performance when doing many consecutive drawing operations, especially in loops, and also allows users to perform drawing operations from multiple threads.
Fixes#92.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.