Skip to content

Add wait parameter to prediction creation methods - #308

Merged
mattt merged 7 commits into
mainfrom
mattt/blocking-run
Sep 25, 2024
Merged

Add wait parameter to prediction creation methods#308
mattt merged 7 commits into
mainfrom
mattt/blocking-run

Conversation

@mattt

@matttmattt commented Sep 23, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@mattt
mattt requested a review from aronSeptember 23, 2024 13:09
aron
aron reviewed Sep 23, 2024
View reviewed changes

@aronaron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention here to roll this out quietly via the block param for testing?

Comment threadindex.js Outdated
Comment threadlib/deployments.js Outdated
@mattt

mattt commented Sep 25, 2024

Copy link
Copy Markdown
ContributorAuthor

Is the intention here to roll this out quietly via the block param for testing?

Sort of. Because of how run wraps createPrediction, we need to make block a parameter to set the right headers in the original request. So most people will continue using replicate.run, but I suppose they could start using predictions.create and opt-in to the same behavior.

@matttmattt changed the title Add block parameter to prediction creation methodsAdd wait parameter to prediction creation methodsSep 25, 2024
@mattt
mattt merged commit 173b31d into mainSep 25, 2024
@mattt
mattt deleted the mattt/blocking-run branch September 25, 2024 18:35
aron
aron reviewed Sep 25, 2024
View reviewed changes
Comment threadindex.d.ts
stream?: boolean;
webhook?: string;
webhook_events_filter?: WebhookEventType[];
block?: boolean;

@aronaronSep 25, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I preferred the version we had that exposed wait here. Where wait was one of:

wait?: {mode: "block",timeout?: number}|{mode: "poll",interval?: number}

This way we have only one param consistently, and it defaults to {mode: "block"}.

@matttmattt mentioned this pull request Oct 1, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aronaronaron left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattt@aron