Skip to content

RFC: Revamp TestUtils & tests - #14

Open
bloodyowl wants to merge 3 commits into
rescript-lang:masterfrom
bloodyowl:revamp-tests
Open

RFC: Revamp TestUtils & tests#14
bloodyowl wants to merge 3 commits into
rescript-lang:masterfrom
bloodyowl:revamp-tests

Conversation

@bloodyowl

@bloodyowlbloodyowl commented Mar 10, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

→ Removes Jest
→ Updates peerDependencies

Test files render

Setup

Screen Shot 2021-03-10 at 13 44 34

Assertions setup

Screen Shot 2021-03-10 at 13 45 02

Tests

Screen Shot 2021-03-10 at 13 43 21

Screen Shot 2021-03-10 at 13 43 44

Test output render

Screen Shot 2021-03-10 at 16 55 09

Screen Shot 2021-03-10 at 16 55 58

JasoonS
JasoonS approved these changes Apr 23, 2021
View reviewed changes

@JasoonSJasoonS left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean to me (although I have zero authority here...)

@cknitt

cknitt commented Sep 30, 2022

Copy link
Copy Markdown
Member

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

@cristianoc

cristianoc commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

@mattdamon108 @cristianoc What about this PR? The previously existing tests were removed in #49. Are we interested in re-adding tests?

Not sure. Do they add value to justify the maintenance? E.g w.r.t. snapshot test where one just looks at the generated code?

Could go either way. No opinion.

@mununki

mununki commented Oct 4, 2022

Copy link
Copy Markdown
Member

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

@cristianoc

cristianoc commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

I have no opinion. Actually, not sure what we should test for the binding module.
One thing that came to my mind is to test the generated js output, maybe?

Checking in che compiled output seems by far the easiest thing. And tells everything there is to know.

jderochervlk
jderochervlk reviewed Oct 15, 2022
View reviewed changes
Comment thread.github/workflows/nodejs.yml
strategy:
matrix:
node-version: [10.x, 12.x]
node-version: [14.x]

@jderochervlkjderochervlkOct 15, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add 16 since it's the current LTS release.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@jderochervlkjderochervlkjderochervlk left review comments
@JasoonSJasoonSJasoonS approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bloodyowl@cknitt@cristianoc@mununki@JasoonS@jderochervlk