Skip to content

Remove unused Base dependency #8655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 2 commits into from
Sep 13, 2026
+3 −6
Merged

Remove unused Base dependency #8655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc7537
Remove unused Base dependency
cknitt Sep 13, 2026
dff8196
Document Base dependency removal
cknitt Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@

#### :house: Internal

- Remove the unused Jane Street `base` dependency left over from vendoring the Flow parser. https://github.com/rescript-lang/rescript/pull/8655
- Refactor parser token handling to separate inspection (`peek`/`peek2`) from consumption, removing Diamond mode and `prev_end_pos` bookkeeping and moving missing JSX prop recovery from an editor-analysis regex heuristic into the parser. https://github.com/rescript-lang/rescript/pull/8633
- Give regexp literals a dedicated AST node. https://github.com/rescript-lang/rescript/pull/8634
- Developer playground: Make panes resizable with wrapping text. https://github.com/rescript-lang/rescript/pull/8628
Expand Down
3 changes: 1 addition & 2 deletions compiler/flow_parser/collections/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@
(library
(name collections)
(wrapped false)
(modules Flow_map Flow_set SSet StringKey)
(libraries base))
(modules Flow_map Flow_set SSet StringKey))
2 changes: 1 addition & 1 deletion compiler/flow_parser/parser/dune
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,6 @@
Statement_parser
Token
Type_parser)
(libraries base wtf8 flow_sedlexing collections)
(libraries wtf8 flow_sedlexing collections)
Comment thread
cknitt marked this conversation as resolved.
(preprocess
(pps ppx_gen_rec ppx_deriving.std flow_sedlexing_ppx)))
2 changes: 0 additions & 2 deletions dune-project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@
(ocaml
(>= 5.0.0))
dune
(base
(>= v0.16.3))
(ppxlib
(>= 0.38.0))
(ppx_deriving :build)
Expand Down
1 change: 0 additions & 1 deletion rescript.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ bug-reports: "https://github.com/rescript-lang/rescript-compiler/issues"
depends: [
"ocaml" {>= "5.0.0"}
"dune" {>= "3.17"}
"base" {>= "v0.16.3"}
"ppxlib" {>= "0.38.0"}
"ppx_deriving" {build}
"ppx_gen_rec" {build}
Expand Down
Loading