Skip to content

Header value null check - #2241

Merged
alexeyzimarev merged 5 commits into
devfrom
header-null
Jul 11, 2024
Merged

Header value null check#2241
alexeyzimarev merged 5 commits into
devfrom
header-null

Conversation

@alexeyzimarev

Copy link
Copy Markdown
Member

Description

Ensure that when adding a header parameter with null value, it throws immediately, without waiting for request execution.
Allow multiple header values for one header key, also support properly adding header parameters with multiple values per header.

Fixes#2227
Fixes#2235

Purpose

This pull request is a:

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@github-actions

github-actionsBot commented Jul 11, 2024

Copy link
Copy Markdown

Test Results

35 files 35 suites 19m 56s ⏱️
438 tests 438 ✅ 0 💤 0 ❌
2 965 runs 2 965 ✅ 0 💤 0 ❌

Results for commit df05ab9.

♻️ This comment has been updated with latest results.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jul 11, 2024

Copy link
Copy Markdown

Deploying restsharp with Cloudflare Pages Cloudflare Pages

Latest commit:df05ab9
Status: ✅ Deploy successful!
Preview URL:https://6c8d447f.restsharp.pages.dev
Branch Preview URL:https://header-null.restsharp.pages.dev

View logs

@alexeyzimarev
alexeyzimarev merged commit 4ddda24 into devJul 11, 2024
@repo-ranger
repo-rangerBot deleted the header-null branch July 11, 2024 17:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected behavoir when upgrading to 111.3.0 NullReferenceException in ExecutePost when Header value is null

1 participant

@alexeyzimarev