Skip to content

Fix for #231 Support for LinkedIn Field-Selector Notation - #250

Merged
ayoung merged 3 commits into
restsharp:masterfrom
devatwork:master
May 9, 2012
Merged

Fix for #231 Support for LinkedIn Field-Selector Notation#250
ayoung merged 3 commits into
restsharp:masterfrom
devatwork:master

Conversation

@devatwork

Copy link
Copy Markdown
Contributor

Fixes the broken .NET RFC 3986 encoding for Uri.EscapeDataString, which causes the LinkedIN field selector signature generation bug.

See the following stackoverflow question about the implementation details of this fix.
http://stackoverflow.com/questions/846487/how-to-get-uri-escapedatastring-to-comply-with-rfc-3986.

I ran all the units and my own LinkedIN tests with this fix succesfully.

Fixes the broken .NET RFC 3986 encoding for Uri.EscapeDataString
@devatwork

Copy link
Copy Markdown
ContributorAuthor

I just added a test for this fix.

Let me know if there is something wrong with the code.

@ayoung
ayoung merged commit 150e5fe into restsharp:masterMay 9, 2012
@ayoung

Copy link
Copy Markdown
Contributor

Just pulled this in. Thanks.

I had to modify this a bit to be compatible with Windows Phone. It doesn't have the Uri.HexEscape method so I just hard coded a hex map.

@devatwork

Copy link
Copy Markdown
ContributorAuthor

Hi Andrew, thanks for pulling the change in. I am installing the Windows Phone SDK now to make sure future pull requests do work on Windows Phone.

@ayoung

Copy link
Copy Markdown
Contributor

new version on nuget coming soon.

On Wednesday, May 9, 2012 at 0:19, Bert Willems wrote:

Hi Andrew, thanks for pulling the change in. I am installing the Windows Phone SDK now to make sure future pull requests do work on Windows Phone.


Reply to this email directly or view it on GitHub:
#250 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@devatwork@ayoung