Skip to content

Update tekton example README and file names - #65

Merged
a-roberts merged 1 commit into
rhd-gitops-example:masterfrom
Megan-Wright:tekton-example
Apr 30, 2020
Merged

Update tekton example README and file names#65
a-roberts merged 1 commit into
rhd-gitops-example:masterfrom
Megan-Wright:tekton-example

Conversation

@Megan-Wright

Copy link
Copy Markdown
Contributor

For: #53

  • Restructures the files so they can be applied to a cluster more easily
  • Renames some files to be more readable
  • Updates readme to reflect file structure changes and simplify

@a-roberts

Copy link
Copy Markdown
Contributor

Thanks @Megan-Wright, I'll take a look at this one and try it 😄

And then let's do a follow-up for tkn, I see tektoncd/cli#940 is being worked so that's a good find

@a-robertsa-roberts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added what I've picked up on the docs so far, giving this a try now (and in fairness to @Megan-Wright I know the text was already here, but now's a good time to clean things up and make it easier to understand)

Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md
Comment threadtekton-example/README.md Outdated
Comment threadtekton-example/README.md Outdated
@a-roberts
a-roberts self-requested a review April 29, 2020 13:56
@CarolynMabbott

Copy link
Copy Markdown
Contributor

I'll have a look too

@Megan-Wright
Megan-Wrightforce-pushed the tekton-example branch 14 times, most recently from 51b5dcf to 334cb30CompareApril 30, 2020 10:39

@a-robertsa-roberts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks Megan, I noticed the example pipeline here is doing a Docker build and the example repositories we reference aren't of the gitops structure we'd like (i.e. those in the main readme), happy to address as a follow-up issue though. After this morning's tests I think we're almost there.

For the last section on the promote run - so I need a third repository then? Update: I do, that TaskRun worked fine, let's update that and address any follow-ups separately.

@a-roberts
a-roberts merged commit 379c24b into rhd-gitops-example:masterApr 30, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Megan-Wright@a-roberts@CarolynMabbott