Skip to content

Document automerge - #75

Merged
dibbles merged 6 commits into
rhd-gitops-example:masterfrom
mnuttall:automerge
May 19, 2020
Merged

Document automerge#75
dibbles merged 6 commits into
rhd-gitops-example:masterfrom
mnuttall:automerge

Conversation

@mnuttall

Copy link
Copy Markdown
Collaborator

This PR provides documentation and Tekton samples showing how Pull Requests may be merged automatically where deemed appropriate.

@mnuttall
mnuttall requested a review from dibblesMay 12, 2020 13:24

@dibblesdibbles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor points for clarrification/discussion - I will attempt to test this later.

Comment threadautomerge/README.md Outdated
Comment threadautomerge/README.md Outdated
- In `github-secret.yaml` replace `[your-github-token-with-repo-access]` with your base64-encoded token. Run this command to get the right string:

```sh
echo -n [your-token] | base64

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You could have used stringData rather than data in the yaml file, then I do not believe you need to do the base64 conversion in advance. (I'm pretty sure if your yaml states stringData, kube does the base64 conversion when the yaml is applied - up to you whether you test this and change)

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment threadautomerge/README.md Outdated

@dibblesdibbles left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got this going once I was on tekton v0.11.3 not 12 :)

@dibbles
dibbles merged commit b4b4464 into rhd-gitops-example:masterMay 19, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mnuttall@dibbles