Skip to content

Add lint workflow_call input conflict with required and default - #154

Merged
rhysd merged 1 commit into
rhysd:mainfrom
sksat:lint-workflow-input-required
Jun 22, 2022
Merged

Add lint workflow_call input conflict with required and default#154
rhysd merged 1 commit into
rhysd:mainfrom
sksat:lint-workflow-input-required

Conversation

@sksat

@sksat sksat commented Jun 20, 2022

Copy link
Copy Markdown
Contributor

I want to lint below invalid reusable workflow

on:
  workflow_call:
    inputs:
      test_input:
        description: test
        type: string
        required: true  # set this input is required
        default: a      # but default value is provided

When we call this workflow without test_input, it results like this. I made this mistake sometimes.

The workflow is not valid. Input test_input is required, but not provided while calling.

@rhysd

rhysd commented Jun 22, 2022

Copy link
Copy Markdown
Owner

Thank you for adding the check. It makes sense to me. I may tweak the error message later. CI is broken, but it is not related to changes by this PR. Merging.

@rhysd

rhysd commented Jun 26, 2022

Copy link
Copy Markdown
Owner

This change was included in the latest release v1.6.14.

@sksat

sksat commented Jun 26, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I forgot to add tests... I'll be careful next time. Thanks for release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants