Change resource used for testing resource-response

[The-Alchemist]

Change resource used for testing resource-response

When testing with alternative Clojure implementations the Clojure core
namespaces are not guaranteed to be in a jarfile, so change the
resource to a pom.properties file, which we know must be in a jar and
not on the filesystem (for example, via a Leiningen checkout).

[weavejester]

The test you've modified is explicitly checking resources from a jar file are returned as an InputStream, so changing it to check for a File as well defeats the point of the test.

What circumstances are you running the tests under that the clojure.java.io namespace isn't in a jar?

[The-Alchemist]

Indeed, great point. This is an quite unique oddball case, as I'm working another Clojure fork like Babashka called Cloffle https://github.com/The-Alchemist/cloffle-clojure), so the files are exploded.

I'm using ring as one of the projects to make sure we compare against, and I'm trying to avoid carrying a patch for just this test case (everything else passes).

Maybe there's a better way to achieve this goal?

[weavejester]

The test needs a jar file on the classpath. As I'm unfamiliar with your setup, I'm unsure how best to go about solving this. Are all dependencies exploded, or just Clojure core? Could we just use a different resource?

[The-Alchemist]

The test needs a jar file on the classpath. As I'm unfamiliar with your setup, I'm unsure how best to go about solving this. Are all dependencies exploded, or just Clojure core? Could we just use a different resource?

Just Clojure code is exploded. So we can just check any resource on the classpath. I force-pushed a new change that checks the file META-INF/maven/org.ring-clojure/ring-core-protocols/pom.properties instead. What do you think @weavejester ?

[weavejester]

That seems fine. Can you ensure all lines are under 80 characters and change the commit message to:

Change resource used for testing resource-response
When testing with alternative Clojure implementations the Clojure core
namespaces are not guaranteed to be in a jarfile, so change the
resource to a pom.properties file, which we know must be in a jar and
not on the filesystem (for example, via a Leiningen checkout).