Uh oh!
There was an error while loading. Please reload this page.
support faster texture updates for vulkan renderer - #72
Open
tfortes wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a Vulkan-specific fast path for image texture creation by allowing callers to supply an existing Vulkan staging buffer directly, avoiding an internal buffer allocation and CPU memcpy during texture uploads.
Changes:
- Refactors
vkutil::Texture2D::scheduleUpload(const void*, size_t)to allocate/copy into a temporary buffer and delegate to a new buffer-based overload. - Introduces
vkutil::Texture2D::scheduleUpload(rcp<vkutil::Buffer>)to enable deferred uploads from caller-provided buffers. - Adds a
RenderContextVulkanImpl::makeImageTexture(...)overload that accepts anrcp<vkutil::Buffer>containing RGBA premultiplied data.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| renderer/src/vulkan/vkutil.cpp | Refactors upload scheduling and adds a new buffer-based upload path. |
| renderer/include/rive/renderer/vulkan/vkutil.hpp | Exposes the new Texture2D::scheduleUpload(rcp<vkutil::Buffer>) overload. |
| renderer/src/vulkan/render_context_vulkan_impl.cpp | Adds a Vulkan-only makeImageTexture overload that takes a pre-existing buffer. |
| renderer/include/rive/renderer/vulkan/render_context_vulkan_impl.hpp | Declares the new Vulkan-only makeImageTexture overload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+284
to
288
| void Texture2D::scheduleUpload(rcp<vkutil::Buffer> imageBuffer) | ||
| { | ||
| m_imageUploadBuffer = imageBuffer; | ||
| m_imageUploadBuffer->flushContents(); | ||
| } |
Comment on lines
+91
to
+96
| rcp<Texture> RenderContextVulkanImpl::makeImageTexture( | ||
| uint32_t width, uint32_t height, uint32_t mipLevelCount, | ||
| rcp<vkutil::Buffer> imageBufferRGBAPremul) | ||
| { | ||
| assert(imageBufferRGBAPremul->info().size >= height * width * 4); | ||
| auto texture = m_vk->makeTexture2D({ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the caller can now provide the vulkan buffer directly, avoiding an allocation and copy.