[Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

Description

@Kerumen

Mapbox Implementation

Mapbox

Mapbox Version

11.20.1

React Native Version

0.86.2

Platform

Android

@rnmapbox/maps version

10.3.1 (also present on main)

Standalone component to reproduce

import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

Observed behavior and steps to reproduce

The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

densityeffective target
1x (mdpi)44dp (correct)
2x (xhdpi)~22dp
3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

Steps:

  1. Render the component above on a 3x-density Android device.
  2. Tap a few dp away from the dot's centre (still visually on/next to it).
  3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

Expected behavior

The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

Notes / preliminary analysis

The units are mismatched at the point where the hitbox meets the screen coordinate.

RNMBXMapView.onMapClick obtains the tap position in physical pixels:

val screenPointPx = mMap?.pixelForCoordinate(point)

That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
val screenBox =ScreenBox(
ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
)

hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

/** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

val screenBox = toPx(ScreenBox(
ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
))

Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

Additional links and references

  • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
  • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
  • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      , 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
       blocks
      (function() {
      function addCopyButtons() {
      document.querySelectorAll('pre code').forEach(function(codeBlock) {
      if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
      codeBlock.parentElement.setAttribute('data-copy-added', 'true');
      var btn = document.createElement('button');
      btn.textContent = 'Copy';
      btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
      btn.onmouseover = function() { this.style.opacity = '1'; };
      btn.onmouseout = function() { this.style.opacity = '0.7'; };
      btn.onclick = function() {
      navigator.clipboard.writeText(codeBlock.textContent).then(function() {
      btn.textContent = 'Copied!';
      setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
      });
      };
      codeBlock.parentElement.style.position = 'relative';
      codeBlock.parentElement.appendChild(btn);
      });
      }
      addCopyButtons();
      // Re-run on dynamic content
      var observer = new MutationObserver(addCopyButtons);
      observer.observe(document.body, { childList: true, subtree: true });
      })();
      }
      } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
      })();
      (function(){
      try {
      var __m = "github.com";
      var __re = new RegExp('^' + "github\\.com" + '
      
      Skip to content

      [Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

      Description

      @Kerumen

      Mapbox Implementation

      Mapbox

      Mapbox Version

      11.20.1

      React Native Version

      0.86.2

      Platform

      Android

      @rnmapbox/maps version

      10.3.1 (also present on main)

      Standalone component to reproduce

      import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

      Observed behavior and steps to reproduce

      The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

      densityeffective target
      1x (mdpi)44dp (correct)
      2x (xhdpi)~22dp
      3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

      Steps:

      1. Render the component above on a 3x-density Android device.
      2. Tap a few dp away from the dot's centre (still visually on/next to it).
      3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

      The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

      Expected behavior

      The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

      Notes / preliminary analysis

      The units are mismatched at the point where the hitbox meets the screen coordinate.

      RNMBXMapView.onMapClick obtains the tap position in physical pixels:

      val screenPointPx = mMap?.pixelForCoordinate(point)

      That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

      val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
      val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
      val screenBox =ScreenBox(
      ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
      ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
      )

      hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

      The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

      /** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

      So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

      iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

      Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

      val screenBox = toPx(ScreenBox(
      ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
      ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
      ))

      Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

      Additional links and references

      • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
      • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
      • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

      Metadata

      Metadata

      Assignees

      No one assigned

        Labels

        No labels
        No labels

        Type

        No type

        Projects

        No projects

          Milestone

          No milestone

          Relationships

          None yet

          Development

          No branches or pull requests

          Issue actions

          , 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
          Skip to content

          [Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

          Description

          @Kerumen

          Mapbox Implementation

          Mapbox

          Mapbox Version

          11.20.1

          React Native Version

          0.86.2

          Platform

          Android

          @rnmapbox/maps version

          10.3.1 (also present on main)

          Standalone component to reproduce

          import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

          Observed behavior and steps to reproduce

          The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

          densityeffective target
          1x (mdpi)44dp (correct)
          2x (xhdpi)~22dp
          3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

          Steps:

          1. Render the component above on a 3x-density Android device.
          2. Tap a few dp away from the dot's centre (still visually on/next to it).
          3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

          The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

          Expected behavior

          The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

          Notes / preliminary analysis

          The units are mismatched at the point where the hitbox meets the screen coordinate.

          RNMBXMapView.onMapClick obtains the tap position in physical pixels:

          val screenPointPx = mMap?.pixelForCoordinate(point)

          That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

          val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
          val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
          val screenBox =ScreenBox(
          ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
          ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
          )

          hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

          The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

          /** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

          So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

          iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

          Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

          val screenBox = toPx(ScreenBox(
          ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
          ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
          ))

          Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

          Additional links and references

          • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
          • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
          • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

          Metadata

          Metadata

          Assignees

          No one assigned

            Labels

            No labels
            No labels

            Type

            No type

            Projects

            No projects

              Milestone

              No milestone

              Relationships

              None yet

              Development

              No branches or pull requests

              Issue actions

              , 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
              Skip to content

              [Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

              Description

              @Kerumen

              Mapbox Implementation

              Mapbox

              Mapbox Version

              11.20.1

              React Native Version

              0.86.2

              Platform

              Android

              @rnmapbox/maps version

              10.3.1 (also present on main)

              Standalone component to reproduce

              import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

              Observed behavior and steps to reproduce

              The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

              densityeffective target
              1x (mdpi)44dp (correct)
              2x (xhdpi)~22dp
              3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

              Steps:

              1. Render the component above on a 3x-density Android device.
              2. Tap a few dp away from the dot's centre (still visually on/next to it).
              3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

              The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

              Expected behavior

              The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

              Notes / preliminary analysis

              The units are mismatched at the point where the hitbox meets the screen coordinate.

              RNMBXMapView.onMapClick obtains the tap position in physical pixels:

              val screenPointPx = mMap?.pixelForCoordinate(point)

              That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

              val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
              val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
              val screenBox =ScreenBox(
              ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
              ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
              )

              hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

              The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

              /** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

              So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

              iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

              Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

              val screenBox = toPx(ScreenBox(
              ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
              ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
              ))

              Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

              Additional links and references

              • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
              • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
              • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

              Metadata

              Metadata

              Assignees

              No one assigned

                Labels

                No labels
                No labels

                Type

                No type

                Projects

                No projects

                  Milestone

                  No milestone

                  Relationships

                  None yet

                  Development

                  No branches or pull requests

                  Issue actions

                  , 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
                  Skip to content

                  [Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

                  Description

                  @Kerumen

                  Mapbox Implementation

                  Mapbox

                  Mapbox Version

                  11.20.1

                  React Native Version

                  0.86.2

                  Platform

                  Android

                  @rnmapbox/maps version

                  10.3.1 (also present on main)

                  Standalone component to reproduce

                  import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

                  Observed behavior and steps to reproduce

                  The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

                  densityeffective target
                  1x (mdpi)44dp (correct)
                  2x (xhdpi)~22dp
                  3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

                  Steps:

                  1. Render the component above on a 3x-density Android device.
                  2. Tap a few dp away from the dot's centre (still visually on/next to it).
                  3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

                  The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

                  Expected behavior

                  The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

                  Notes / preliminary analysis

                  The units are mismatched at the point where the hitbox meets the screen coordinate.

                  RNMBXMapView.onMapClick obtains the tap position in physical pixels:

                  val screenPointPx = mMap?.pixelForCoordinate(point)

                  That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

                  val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
                  val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
                  val screenBox =ScreenBox(
                  ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
                  ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
                  )

                  hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

                  The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

                  /** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

                  So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

                  iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

                  Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

                  val screenBox = toPx(ScreenBox(
                  ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
                  ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
                  ))

                  Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

                  Additional links and references

                  • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
                  • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
                  • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

                  Metadata

                  Metadata

                  Assignees

                  No one assigned

                    Labels

                    No labels
                    No labels

                    Type

                    No type

                    Projects

                    No projects

                      Milestone

                      No milestone

                      Relationships

                      None yet

                      Development

                      No branches or pull requests

                      Issue actions

                      , 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                      Skip to content

                      [Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

                      Description

                      @Kerumen

                      Mapbox Implementation

                      Mapbox

                      Mapbox Version

                      11.20.1

                      React Native Version

                      0.86.2

                      Platform

                      Android

                      @rnmapbox/maps version

                      10.3.1 (also present on main)

                      Standalone component to reproduce

                      import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

                      Observed behavior and steps to reproduce

                      The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

                      densityeffective target
                      1x (mdpi)44dp (correct)
                      2x (xhdpi)~22dp
                      3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

                      Steps:

                      1. Render the component above on a 3x-density Android device.
                      2. Tap a few dp away from the dot's centre (still visually on/next to it).
                      3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

                      The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

                      Expected behavior

                      The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

                      Notes / preliminary analysis

                      The units are mismatched at the point where the hitbox meets the screen coordinate.

                      RNMBXMapView.onMapClick obtains the tap position in physical pixels:

                      val screenPointPx = mMap?.pixelForCoordinate(point)

                      That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

                      val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
                      val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
                      val screenBox =ScreenBox(
                      ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
                      ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
                      )

                      hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

                      The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

                      /** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

                      So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

                      iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

                      Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

                      val screenBox = toPx(ScreenBox(
                      ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
                      ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
                      ))

                      Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

                      Additional links and references

                      • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
                      • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
                      • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

                      Metadata

                      Metadata

                      Assignees

                      No one assigned

                        Labels

                        No labels
                        No labels

                        Type

                        No type

                        Projects

                        No projects

                          Milestone

                          No milestone

                          Relationships

                          None yet

                          Development

                          No branches or pull requests

                          Issue actions

                          , 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
                          Skip to content

                          [Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

                          Description

                          @Kerumen

                          Mapbox Implementation

                          Mapbox

                          Mapbox Version

                          11.20.1

                          React Native Version

                          0.86.2

                          Platform

                          Android

                          @rnmapbox/maps version

                          10.3.1 (also present on main)

                          Standalone component to reproduce

                          import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

                          Observed behavior and steps to reproduce

                          The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

                          densityeffective target
                          1x (mdpi)44dp (correct)
                          2x (xhdpi)~22dp
                          3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

                          Steps:

                          1. Render the component above on a 3x-density Android device.
                          2. Tap a few dp away from the dot's centre (still visually on/next to it).
                          3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

                          The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

                          Expected behavior

                          The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

                          Notes / preliminary analysis

                          The units are mismatched at the point where the hitbox meets the screen coordinate.

                          RNMBXMapView.onMapClick obtains the tap position in physical pixels:

                          val screenPointPx = mMap?.pixelForCoordinate(point)

                          That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

                          val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
                          val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
                          val screenBox =ScreenBox(
                          ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
                          ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
                          )

                          hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

                          The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

                          /** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

                          So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

                          iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

                          Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

                          val screenBox = toPx(ScreenBox(
                          ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
                          ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
                          ))

                          Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

                          Additional links and references

                          • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
                          • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
                          • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

                          Metadata

                          Metadata

                          Assignees

                          No one assigned

                            Labels

                            No labels
                            No labels

                            Type

                            No type

                            Projects

                            No projects

                              Milestone

                              No milestone

                              Relationships

                              None yet

                              Development

                              No branches or pull requests

                              Issue actions

                              , 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
                              Skip to content

                              [Bug]: [Android] ShapeSource hitbox is applied in physical pixels, not points — target shrinks with screen density #4285

                              Description

                              @Kerumen

                              Mapbox Implementation

                              Mapbox

                              Mapbox Version

                              11.20.1

                              React Native Version

                              0.86.2

                              Platform

                              Android

                              @rnmapbox/maps version

                              10.3.1 (also present on main)

                              Standalone component to reproduce

                              import*asReactfrom'react';import{MapView,ShapeSource,CircleLayer,Camera}from'@rnmapbox/maps';// Tap slightly off-centre from the dot — say 18dp away. On a 1x/2x device it// registers; on a 3x device it usually does not.constpoint={type: 'Feature'asconst,geometry: {type: 'Point'asconst,coordinates: [2.35,48.86]},properties: {},};constHitboxTest=()=>(<MapViewstyle={{flex: 1}}><CameracenterCoordinate={[2.35,48.86]}zoomLevel={14}animationDuration={0}/><ShapeSourceid="pt"shape={point}onPress={(e)=>console.log('hit',e.features.length)}><CircleLayerid="pt-circle"style={{circleRadius: 6,circleColor: '#c00'}}/></ShapeSource></MapView>);

                              Observed behavior and steps to reproduce

                              The default ShapeSource touch hitbox is documented as 44×44 points, but on Android it behaves as 44×44 physical pixels. The effective touch target therefore shrinks as screen density rises:

                              densityeffective target
                              1x (mdpi)44dp (correct)
                              2x (xhdpi)~22dp
                              3x (xxhdpi, e.g. Pixel 10 Pro)~14.7dp

                              Steps:

                              1. Render the component above on a 3x-density Android device.
                              2. Tap a few dp away from the dot's centre (still visually on/next to it).
                              3. onPress does not fire, while the same offset registers on iOS or on a lower-density device.

                              The dot is harder to hit on Android than on iOS, and gets progressively harder on higher-density hardware. Passing an explicit hitbox works around it, but the value must then be pre-scaled by PixelRatio on Android only — which is itself surprising, since the prop is documented in points.

                              Expected behavior

                              The default hitbox should be 44dp on every density, matching the documented value and the iOS behaviour. An explicit hitbox={{ width, height }} should be interpreted in density-independent points on both platforms, so the same value gives the same physical target size everywhere.

                              Notes / preliminary analysis

                              The units are mismatched at the point where the hitbox meets the screen coordinate.

                              RNMBXMapView.onMapClick obtains the tap position in physical pixels:

                              val screenPointPx = mMap?.pixelForCoordinate(point)

                              That value is passed straight into handleTapInSources, which subtracts the raw hitbox halves from it without any density conversion:

                              val halfWidth = (hitbox["width"]!!.toFloat() /2.0f).toDouble()
                              val halfHeight = (hitbox["height"]!!.toFloat() /2.0f).toDouble()
                              val screenBox =ScreenBox(
                              ScreenCoordinate(screenPoint.x - halfWidth, screenPoint.y - halfHeight),
                              ScreenCoordinate(screenPoint.x + halfWidth, screenPoint.y + halfHeight)
                              )

                              hitbox["width"] is either the JS-supplied number or DEFAULT_HITBOX_WIDTH = 44.0 from RNMBXSource.kt — in both cases a point value, now being subtracted from a pixel coordinate.

                              The file already knows about this distinction, and converts correctly a few lines later for the emitted event:

                              /** Android Mapbox SDK returns screen coordinates in physical pixels, while JS expects density-independent pixels. */val screenPointDp = toDp(screenPointPx)

                              So the outgoing point is converted but the incoming hitbox is not. The same file already has the exact helper needed — private fun toPx(boxDp: ScreenBox): ScreenBox — which is currently unused on this path.

                              iOS is unaffected: RNMBXMapView.swift builds its hitboxRect from a CGPoint that is already in points.

                              Building the box in dp and passing it through that helper would fix it (untested, and I have not opened a PR — the maintainers will know whether the conversion belongs here or in touchHitbox):

                              val screenBox = toPx(ScreenBox(
                              ScreenCoordinate(screenPointDp.x - halfWidth, screenPointDp.y - halfHeight),
                              ScreenCoordinate(screenPointDp.x + halfWidth, screenPointDp.y + halfHeight)
                              ))

                              Note this would change the effective target size for anyone currently compensating with a pre-scaled hitbox, so it is arguably a breaking change on Android.

                              Additional links and references

                              • android/src/main/java/com/rnmapbox/rnmbx/components/mapview/RNMBXMapView.kthandleTapInSources (hitbox subtraction) and onMapClick (pixelForCoordinate / toDp)
                              • android/src/main/java/com/rnmapbox/rnmbx/components/styles/sources/RNMBXSource.ktDEFAULT_HITBOX_WIDTH / DEFAULT_HITBOX_HEIGHT and touchHitbox
                              • Found while working around [Bug]: MapView onPress is slow #3800; unrelated to that issue's latency cause, but it compounds the symptom — taps feel both slow and unreliable on high-density Android.

                              Metadata

                              Metadata

                              Assignees

                              No one assigned

                                Labels

                                No labels
                                No labels

                                Type

                                No type

                                Projects

                                No projects

                                  Milestone

                                  No milestone

                                  Relationships

                                  None yet

                                  Development

                                  No branches or pull requests

                                  Issue actions