Skip to content

Update ExecuteJavascriptMiddleware.php by allowing config of waitUntilNetworkIdle()#202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josezenem wants to merge 3 commits into
base:main
Choose a base branch
from
Open

Update ExecuteJavascriptMiddleware.php by allowing config of waitUntilNetworkIdle() #202

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6844458
Update ExecuteJavascriptMiddleware.php
josezenem Jan 24, 2024
2e0eb3b
Merge branch 'main' into main
josezenem Jan 30, 2024
39e5023
Merge branch 'main' into main
ksassnowski Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Downloader/Middleware/ExecuteJavascriptMiddleware.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -34,7 +34,8 @@
private LoggerInterface $logger,
?callable $getBrowsershot = null,
) {
$this->getBrowsershot = $getBrowsershot ?? static fn (string $uri): Browsershot => Browsershot::url($uri)->waitUntilNetworkIdle();
/** @psalm-suppress MixedInferredReturnType, MixedReturnStatement */
$this->getBrowsershot = $getBrowsershot ?? static fn (string $uri): Browsershot => Browsershot::url($uri);
}

public function handleResponse(Response $response): Response
Expand DownExpand Up@@ -64,6 +65,10 @@
{
$browsershot = ($this->getBrowsershot)($uri);

if (null !== ($waitUntilNetworkIdle = $this->option('waitUntilNetworkIdle'))) {
$browsershot->waitUntilNetworkIdle($waitUntilNetworkIdle);

Check failure on line 69 in src/Downloader/Middleware/ExecuteJavascriptMiddleware.php

View workflow job for this annotation

GitHub Actions/ P8.3 - prefer-stable - ubuntu-latest

Parameter #1 $strict of method Spatie\Browsershot\Browsershot::waitUntilNetworkIdle() expects bool, mixed given.

Check failure on line 69 in src/Downloader/Middleware/ExecuteJavascriptMiddleware.php

View workflow job for this annotation

GitHub Actions/ P8.3 - prefer-lowest - ubuntu-latest

Parameter #1 $strict of method Spatie\Browsershot\Browsershot::waitUntilNetworkIdle() expects bool, mixed given.

Check failure on line 69 in src/Downloader/Middleware/ExecuteJavascriptMiddleware.php

View workflow job for this annotation

GitHub Actions/ P8.2 - prefer-stable - ubuntu-latest

Parameter #1 $strict of method Spatie\Browsershot\Browsershot::waitUntilNetworkIdle() expects bool, mixed given.

Check failure on line 69 in src/Downloader/Middleware/ExecuteJavascriptMiddleware.php

View workflow job for this annotation

GitHub Actions/ P8.4 - prefer-lowest - ubuntu-latest

Parameter #1 $strict of method Spatie\Browsershot\Browsershot::waitUntilNetworkIdle() expects bool, mixed given.

Check failure on line 69 in src/Downloader/Middleware/ExecuteJavascriptMiddleware.php

View workflow job for this annotation

GitHub Actions/ P8.2 - prefer-lowest - ubuntu-latest

Parameter #1 $strict of method Spatie\Browsershot\Browsershot::waitUntilNetworkIdle() expects bool, mixed given.

Check failure on line 69 in src/Downloader/Middleware/ExecuteJavascriptMiddleware.php

View workflow job for this annotation

GitHub Actions/ P8.4 - prefer-stable - ubuntu-latest

Parameter #1 $strict of method Spatie\Browsershot\Browsershot::waitUntilNetworkIdle() expects bool, mixed given.
}

if (!empty($this->option('chromiumArguments'))) {
/** @phpstan-ignore argument.type */
$browsershot->addChromiumArguments($this->option('chromiumArguments'));
Expand DownExpand Up@@ -115,6 +120,7 @@
private function defaultOptions(): array
{
return [
'waitUntilNetworkIdle' => true,
'chromiumArguments' => [],
'chromePath' => null,
'binPath' => null,
Expand Down
Loading