Skip to content

add jquery active wait for finding elemnet - #148

Closed
jollychang wants to merge 5 commits into
robotframework:masterfrom
jollychang:master
Closed

add jquery active wait for finding elemnet#148
jollychang wants to merge 5 commits into
robotframework:masterfrom
jollychang:master

Conversation

@jollychang

Copy link
Copy Markdown
Contributor

for every element find

@j1z0

j1z0 commented Nov 27, 2012

Copy link
Copy Markdown
Contributor

I do like the idea of adding jQuey support but I have a concern with the way it is implemented in this pull request.
The issue I have has to do with performance. I someone is not using jQuery this incurs and extra round trip for every single element find. This make a big difference in overall performance when using a remote client.

I would rather see an option added to the library init such as UseJquery it should default to false abd only call the jQuery bits if its value is true.

@jollychang

Copy link
Copy Markdown
ContributorAuthor

@j1z0 ok,I will try to add as a option

@jollychang

Copy link
Copy Markdown
ContributorAuthor

update as options from import Selenium2Library

@ghostghost assigned j1z0Dec 11, 2012
@peritus

Copy link
Copy Markdown
Contributor

I always implement this in "Robot Framework userland":

*** Keywords ***
Wait For Ajax
Wait for Condition return window.jQuery.active == 0;

And I think it's better kept that way.

@omahlama

Copy link
Copy Markdown

I agree with @peritus, there are cases where you want to do things without waiting for ajax, so the choice should be left to the end user. Maybe documenting this as a typical use scenario would be useful instead.

@peritus

Copy link
Copy Markdown
Contributor

@omahlama Yes, documentation would be great, also could include examples for all popular Ajax wrapping frameworks!

@emanlove

Copy link
Copy Markdown
Member

Consensus seems to be to use a Robot Framework keyword instead of suggested pull request. Added issue #175.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jollychang@j1z0@peritus@omahlama@emanlove