Skip to content

Fix android build - #18

Merged
gavv merged 4 commits into
masterfrom
fix-android-build
Jun 10, 2020
Merged

Fix android build#18
gavv merged 4 commits into
masterfrom
fix-android-build

Conversation

@MatteoArella

@MatteoArellaMatteoArella commented Jun 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

This PR contains following fixes:

  • removed soversion from libroc.so library
  • LogLevel class caching during JNI_OnLoad
  • fix thread attaching and detaching on logger_handler
  • added internet permissions to AndroidManifest.xml

/resolve#15
/resolve#16

@MatteoArella
instrumented test with gradle
05aa02c
removed soversion from soname, LogLevel class caching, fix thread attaching and detaching on logger_handler
added internet permissions to AndroidManifest
@MatteoArella
MatteoArella requested review from gavv and ortexJune 5, 2020 13:51
@ortex

ortex commented Jun 6, 2020

Copy link
Copy Markdown
Member

I've tested changes. Fixes for logger and build are working 👍

ortex
ortex reviewed Jun 6, 2020
View reviewed changes
Comment threadandroid/roc-android/build.gradle Outdated
Comment threadroc_jni/src/main/cpp/logger.cpp
Comment threadroc_jni/src/main/cpp/logger.cpp Outdated
@ortex

ortex commented Jun 6, 2020

Copy link
Copy Markdown
Member

LGTM

gavv
gavv reviewed Jun 7, 2020
View reviewed changes
Comment threadscripts/travis/android/entrypoint/install.sh Outdated
gavv
gavv reviewed Jun 7, 2020
View reviewed changes
Comment threadroc_jni/src/main/cpp/logger.cpp
@MatteoArellaMatteoArella mentioned this pull request Jun 9, 2020
Open
@gavv

gavv commented Jun 10, 2020

Copy link
Copy Markdown
Member

LGTM!

@gavv
gavv merged commit bcbb39d into masterJun 10, 2020
@gavv
gavv deleted the fix-android-build branch June 10, 2020 14:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ortexortexortex left review comments
@gavvgavvgavv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix android aar build Fix logger on android

3 participants

@MatteoArella@ortex@gavv