Uh oh!
There was an error while loading. Please reload this page.
Add submit-batch command and to-json flags for multi-setting proposals - #1171
Merged
Conversation
Merging this branch changes the coverage (3 decrease, 3 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a
--to-json <file>flag to every rocketpool pdao propose setting command so a setting is written or appended to a JSON file instead of submitted as its own transaction. Re-running the same contract and setting path replaces that entry.rocketpool pdao propose submit-batchthen submits the whole file as one Protocol DAO proposal via proposalSettingMulti. The json file should follow this schema:[
{
"contract": "rocketDAOProtocolSettingsAuction",
"setting": "auction.lot.create.enabled",
"type": "bool",
"value": "true"
},
{
"contract": "rocketDAOProtocolSettingsDeposit",
"setting": "deposit.minimum",
"type": "uint256",
"value": "1000000000000000000"
}
]
Closes#755