Uh oh!
There was an error while loading. Please reload this page.
docs: User Guide, restructure, add versioning - #353
Conversation
📝 WalkthroughWalkthroughReplaces the GitHub Pages OIDC deployment workflow with a versioned ChangesVersioned Docs Deployment and Restructure
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
eac8738 to
e01f95eCompare…rop cache Pass inputs.ref and steps.deploy-path.outputs.path through env vars instead of expanding them directly in shell scripts to avoid template injection. Remove the actions/cache step for the mdbook binary; the download is fast enough that caching isn't worth the cache-poisoning audit finding.
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
docs/theme/fonts/fonts.css (1)
1-1: 💤 Low valueApply stylelint-preferred import notation.
The
import-notationrule prefers a quoted string instead of theurl()function syntax. Both are functionally equivalent; this is purely a style preference.✨ Proposed style fix
-@import url('https://fonts.googleapis.com/css2?family=Funnel+Display:wght@300..800&family=Funnel+Sans:ital,wght@0,300..800;1,300..800&display=swap');+@import 'https://fonts.googleapis.com/css2?family=Funnel+Display:wght@300..800&family=Funnel+Sans:ital,wght@0,300..800;1,300..800&display=swap';🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/theme/fonts/fonts.css` at line 1, The `@import` statement in fonts.css currently uses the url() function syntax, but stylelint prefers quoted string notation for consistency. Replace the `@import` url('...') syntax with `@import` '...' by removing the url() function wrapper and keeping just the quoted string with the Google Fonts URL.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/mdbook.yml:
- Around line 90-115: The mdBook workflow builds with a static site-url but
deploys to versioned subdirectories, causing asset and 404 paths to be
incorrect. Before the mdBook build step (which occurs before the deployment
section shown), set the MDBOOK_OUTPUT_HTML_SITE_URL environment variable
dynamically by constructing it from the DEPLOY_PATH output. For example, set
MDBOOK_OUTPUT_HTML_SITE_URL to "/osprey/${DEPLOY_PATH}" or similar, ensuring the
site-url matches the actual deployment path. This environment variable will
override the static site-url in book.toml during the build, so the generated
404.html and asset paths will be correct for each versioned deployment.
In `@docs/theme/fonts/fonts.css`:
- Around line 17-19: The fonts.css stylesheet exists at
docs/theme/fonts/fonts.css but is not integrated into the documentation build.
Add the additional-css configuration to the [output.html] section of
docs/book.toml to reference the stylesheet. Include the relative path
"theme/fonts/fonts.css" in the additional-css array so that custom font and link
styles (such as the .content a text-decoration rule) are applied when the
documentation is built.
---
Nitpick comments:
In `@docs/theme/fonts/fonts.css`:
- Line 1: The `@import` statement in fonts.css currently uses the url() function
syntax, but stylelint prefers quoted string notation for consistency. Replace
the `@import` url('...') syntax with `@import` '...' by removing the url() function
wrapper and keeping just the quoted string with the Google Fonts URL.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1f2fabe9-9e9a-413c-bb48-78f8a72b56ab
📒 Files selected for processing (19)
.github/workflows/mdbook.ymldocs/README.mddocs/SUMMARY.mddocs/UI.mddocs/book.tomldocs/development/README.mddocs/development/ide.mddocs/development/tools.mddocs/development/troubleshooting.mddocs/docs.mddocs/research-personas.mddocs/rules.mddocs/theme/fonts/fonts.cssdocs/user/README.mddocs/user/investigate/README.mddocs/user/investigate/labels.mddocs/user/investigate/query-syntax.mddocs/user/manage.mddocs/user/operate.md
💤 Files with no reviewable changes (1)
- docs/UI.md
✅ Files skipped from review due to trivial changes (14)
- docs/user/README.md
- docs/user/investigate/labels.md
- docs/README.md
- docs/docs.md
- docs/development/troubleshooting.md
- docs/user/manage.md
- docs/development/tools.md
- docs/user/investigate/README.md
- docs/rules.md
- docs/user/investigate/query-syntax.md
- docs/development/ide.md
- docs/user/operate.md
- docs/SUMMARY.md
- docs/development/README.md
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/book.toml
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Pass of the docs to more clearly separate into a user guide and development guide, similar to the Coop docs.
Summary by CodeRabbit
Documentation
Build & Release