Uh oh!
There was an error while loading. Please reload this page.
Disable flake8 - #111
Merged
Merged
Conversation
This fixes CI while we wait for an upstream issue to be resolved. See ament/ament_lint#252 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
clalancette
approved these changes
Jun 23, 2020
clalancette
left a comment
Contributor
There was a problem hiding this comment.
This is a fine short-term workaround, we can look at re-enabling it later.
esteve
commented
Jun 24, 2020
Member
Why was this merged if ament/ament_lint#252 got merged? |
jacobperron
commented
Jun 24, 2020
ContributorAuthor
We'll have to wait for the next Dashing sync before ament/ament_lint#252 takes effect. |
jacobperron added a commit
that referenced
this pull request
May 17, 2021
This fixes CI while we wait for an upstream issue to be resolved. See ament/ament_lint#252 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit
that referenced
this pull request
May 17, 2021
This fixes CI while we wait for an upstream issue to be resolved. See ament/ament_lint#252 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes CI while we wait for an upstream issue to be resolved.
See ament/ament_lint#252
I think it would be nice to fast-forward
masterto matchdashingafter this and #110 land. Then we can start updatingmasterwith patches for Eloquent and Foxy.