Make opencv-python a pip dependency for Windows. - #317
Conversation
That way it will get properly installed in both debug and non-debug versions. Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
| # python_qt_bindings can't be imported to run or test rqt_graph or | ||
| # rqt_py_common. | ||
| if sys.platform == 'win32' and args.cmake_build_type == 'Debug': | ||
| # There are no Windows debug packages available for opencv-python, so |
| ] | ||
| if sys.platform == 'win32' and not args.cmake_build_type == 'Debug': | ||
| pip_dependencies += [ | ||
| 'opencv-python', |
There was a problem hiding this comment.
Will opencv-python from pypi work with our opencv binary?
There was a problem hiding this comment.
A follow up question would be why doesn't our opencv binary include opencv-python?
There was a problem hiding this comment.
That could potentially fix the debug builds as well.
There was a problem hiding this comment.
Will opencv-python from pypi work with our opencv binary?
Yes and no. opencv-python is its own compiled version of the library, and doesn't use our version. Because of this, there is a potential of version drift between them (we currently package OpenCV 3.4, while opencv-python from pip is currently 4.10).
A follow up question would be why doesn't our opencv binary include opencv-python?
Yeah, maybe that is the right way to go. I guess we'd have to figure out how to make that compile happen, and then we'd also have to figure out how to tell users to unpack properly to C:\python37 and/or setup PYTHONPATH. @mjcarroll , up for a challenge? :).
That could potentially fix the debug builds as well.
Only if you can include both the debug and release .pyd files in the same tarball. Can you?
There was a problem hiding this comment.
Only if you can include both the debug and release
.pydfiles in the same tarball. Can you?
I believe there's some dark magic in the CI scripts to uninstall and reinstall python extensions on Windows so the correct Debug or Release library is used.
|
Giving up on this one, we'll decide whether to do this another day. |
That way it will get properly installed in both debug
and non-debug versions.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org