ExecuteProcess not returning on_exit actions in describe_conditional_sub_entities

[pbaughman]

Feature request

Launch actions are supposed to return their sub-entities and conditional sub-entities to so they can be introspected before running.

The ExecuteProcess action does not provide an implementation of these methods, so anything run on_exit can not be introspected

Feature description

Implement get_sub_entities in ExecuteProcess so that we can discover on_exit actions. One place where this is causing a problem right now is here launch_testing can't discover the ReadyToTest action (or even the `daemon-start' process) because it's nested down in on_exit

Implementation considerations

???

[hidmic]

Looks like I inadvertently fixed this in #353. Closing.

[pbaughman]

@hidmic I had an in person conversation with @wjwwood where he suggested the sub-entities needed to include the event handlers and events that are plumbed into the launch context when you call 'execute'

It's possible that you've un-jammed my PR here though (for which you're a wonderful human being and I thank you) but maybe William can chime in about whether or not we should keep this issue open and I can fill in the "Implementation considerations" section above a bit better

[hidmic]

@hidmic I had an in person conversation with @wjwwood where he suggested the sub-entities needed to include the event handlers and events that are plumbed into the launch context when you call 'execute'

I see, I wasn't aware. I do not have a strong opinion, though those event handlers seem an implementation detail to me. Anyways, we haven't really drawn a line between what's introspectable and what not (or even decided if such a line should exist).

[pbaughman]

Yeah, I don't feel strongly either. I think William's idea was that the 'Register Event Handler' entities were unconditional sub-entities of an execute-process, and then the on-process-exit actions would be conditional sub-entities of THOSE entities.

I think you've fixed the problem I had in my head when I opened this issue. One of the reasons it sat open was that the solution I was considering was much more complicated.

[wjwwood]

I think William's idea was that the 'Register Event Handler' entities were unconditional sub-entities of an execute-process, and then the on-process-exit actions would be conditional sub-entities of THOSE entities.

That's right.