Add PathJoinSubstitution - #266
Merged
Merged
Conversation
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
sloretz
reviewed
Jun 24, 2019
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Tests for the ThisLaunchFileDir substitution class.""" |
Contributor
There was a problem hiding this comment.
nit, wrong name in docstring
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
Member
Author
|
Full CI (up to launch):
|
sloretz
approved these changes
Jun 24, 2019
delete-merged-branch
Bot
deleted the
ivanpauno/add-path-join-substitution
branch
June 24, 2019 17:23
piraka9011
pushed a commit
to aws-ros-dev/launch
that referenced
this pull request
Aug 16, 2019
Signed-off-by: ivanpauno <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convenient substitution.
For example here:
https://github.com/ros2/ros2cli/blob/96c3a7d49cbf6fabcfe587c63bca3f01577a8b6c/test_ros2cli/test/test_process_output_customizable.py.in#L38
from ros2/ros2cli#287.
It would be better to use: