Fix launch_testing output filtering - #296
Merged
Merged
Conversation
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Author
|
CI (up to
|
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
reviewed
Aug 7, 2019
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ivanpauno
approved these changes
Aug 7, 2019
Author
|
Alright, going in ! |
piraka9011
pushed a commit
to aws-ros-dev/launch
that referenced
this pull request
Aug 16, 2019
* Fix launch_testing output filtering. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Add test case for launch_testing.tools.basic_output_filter Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Replace os.linesep with '\n' Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com> * Deal with all possible line boundaries. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. A spin off from #279, as it's orthogonal to CLI testing.