[launch_testing] remove deprecated ready_fn feature

[wjwwood]

This feature was deprecated in #346 (foxy) and should be removed by now, so we'll do it in Humble.

We realized this due to this pr (thanks for that btw): #580

I'm opening in draft because I quickly did this in the browser and I'm not sure if the related ReadyAggregator class needs to be removed. So I'll let CI run first.

CI is good, but I'm still not sure about the ReadyAggregator class, looking for input on that.

[wjwwood]

Preliminary CI:

• Linux
• Linux-aarch64
• Windows

[adityapande-1995]

Should this line be removed as well ?

launch/launch_testing/launch_testing/test_runner.py

Line 74 in 73fa05e

ready_fn=lambda: self._processes_launched.set()

[wjwwood]

The short answer is: "I don't know"

I looked at that line, but I couldn't figure out if it is part of the test runner machinery that is unfortunately named the same as the old feature users would use, or not. That's why I ran CI, I figured that if it was the old feature I'm removing some tests should fail, but maybe that's not the case.

I also sort of traced the logic and I believe that it is still used, but the difference is that the ready_fn is passed to the wrapper and not the launch_description_fn, as it used to be.

Maybe someone more familiar with launch_testing like @ivanpauno or @hidmic could comment on it.

[hidmic]

Should this line be removed as well ?

@adityapande-1995 @wjwwood It shouldn't. That's the actual callable that the ReadyToTest action eventually invokes.

I looked at that line, but I couldn't figure out if it is part of the test runner machinery that is unfortunately named the same as the old feature users would use, or not.

TBH this whole thing is messy.

[hidmic]

@wjwwood LGTM but

launch/launch_testing/launch_testing/test_runner.py

Lines 295 to 296 in b59bb6b

	if argname == 'ready_fn':
	continue

should be removed too.

[wjwwood]

CI:

• Linux
• Linux-aarch64
• Windows

[hidmic]

@wjwwood linters were still failing in that last CI.

[wjwwood]

New CI:

• Linux
• Linux-aarch64
• Windows

[ivanpauno]

LGTM!

[audrow]

Looks good to me!