[Feature] Return parameter name on get_parameter exception

[maxlein]

Wouldn't it be a nice feature to return the missing parameter name instead of just throwing that some parameter is missing?

Something like this:

template<typename T>
   T get_parameter(const std::string & parameter_name)
   {
     auto error = fmt::format("Parameter {} not set!", parameter_name);
     return get_parameter_impl(
              parameter_name,
              std::function<T()>([&]() -> T {throw std::runtime_error( error.c_str() );}));
   }`

[ivanpauno]

What method are you calling? Could you provide an example please?

It is always nice to have the clearer error message as possible, so adding the parameter name is a good idea.
What is not clear from your description is where that is missing.

If you find the place it is missing, consider sending a PR addressing this, thanks!

[maxlein]

I am calling exactly the method shown above from parameter_client.hpp, just with the parameter name output added.

And as I am looking this up on the repo, I see it was already added to the source. #833
In my Dashing release its not included yet.

[ivanpauno]

Closing, as it has been solved by #833.

If you want the fix in Dashing, please open a backport PR (i.e. a PR targeting dashing branch with 64c0f86 cherry-picked).