fix race in test_lifecycle_service_client - #1204
Merged
Merged
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
brawner
approved these changes
Jun 26, 2020
brawner
left a comment
Contributor
There was a problem hiding this comment.
Thanks Dirk for addressing this issue.
DensoADAS
pushed a commit
to DensoADAS/rclcpp
that referenced
this pull request
Jul 7, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
ahcorde
pushed a commit
that referenced
this pull request
Nov 3, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
ahcorde
pushed a commit
that referenced
this pull request
Nov 3, 2020
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
bartalor
pushed a commit
to bartalor/rclcpp
that referenced
this pull request
Jul 15, 2026
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Tanay10x
pushed a commit
to TanayK07/ros2_pulse
that referenced
this pull request
Aug 23, 2026
#1204 was an internal monorepo tracker, not a ros2/rclcpp ref -- the public ros2/rclcpp#1204 is an unreleated lifecycle-service-client test race, so it reads as a dead link. Inline the description (the earlier global-mutex + per-message string-hash stats prototype) in the interposers.cpp comment and in bench/RESULTS.md. Comment-only change in interposers.cpp; no logic touched.
Tanay10x
pushed a commit
to TanayK07/ros2_pulse
that referenced
this pull request
Aug 23, 2026
#1204 was an internal monorepo tracker, not a ros2/rclcpp ref -- the public ros2/rclcpp#1204 is an unreleated lifecycle-service-client test race, so it reads as a dead link. Inline the description (the earlier global-mutex + per-message string-hash stats prototype) in the interposers.cpp comment and in bench/RESULTS.md. Comment-only change in interposers.cpp; no logic touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a race between one thread spinning and calling
rclcpp::shutdown()from another thread by making the critical sections mutually exclusive.The test has been failing since the first nightly build (https://ci.ros2.org/view/nightly/job/nightly_osx_repeated/1939/testReport/(root)/projectroot/test_lifecycle_service_client/) after being added in #1045.
Before:
After: