Skip to content

fix allocator type - #270

Merged
dirk-thomas merged 1 commit into
masterfrom
composition
Nov 11, 2016
Merged

dirk-thomas merged 1 commit into
masterfrom
composition

Conversation

@dirk-thomas

Copy link
Copy Markdown
Member

Otherwise this code fails the stricter static assertion added in libc++ 3.9.

In file included from /Users/osrf/jenkins/workspace/ci_osx/ws/src/ros2/rclcpp/rclcpp/include/rclcpp/intra_process_manager_impl.hpp:22:
/usr/local/Cellar/llvm/3.9.0/bin/../include/c++/v1/map:820:5: error: static_assert failed "Allocator::value_type must be same type as value_type"
static_assert((is_same<typename allocator_type::value_type, value_type>::value),

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Nov 10, 2016
@dirk-thomas dirk-thomas self-assigned this Nov 10, 2016

@wjwwood wjwwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to run CI before merging, otherwise lgtm.

@dirk-thomas

Copy link
Copy Markdown
Member Author

ros2/demos#84 (comment) contains the jobs for this branch.

@dirk-thomas
dirk-thomas merged commit 5894a9c into master Nov 11, 2016
@dirk-thomas
dirk-thomas deleted the composition branch November 11, 2016 00:55
@dirk-thomas dirk-thomas removed the in review Waiting for review (Kanban column) label Nov 11, 2016
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants